Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: tools/buildbot_spec.py

Issue 1346833004: Test-...-Release-SK_FOO --> -DSK_FOO (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: undo Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/buildbot_spec.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/buildbot_spec.py
diff --git a/tools/buildbot_spec.py b/tools/buildbot_spec.py
index b379366973c4061a989da964f8c0d7a2ee036ac9..f360a38778a92732a025c94b97dd790894a0fcdd 100755
--- a/tools/buildbot_spec.py
+++ b/tools/buildbot_spec.py
@@ -140,10 +140,6 @@ def gyp_defines(builder_dict):
builder_dict.get('cpu_or_gpu_value') == 'Mesa'):
gyp_defs['skia_mesa'] = '1'
- # SKNX_NO_SIMD
- if builder_dict.get('extra_config') == 'SKNX_NO_SIMD':
- gyp_defs['sknx_no_simd'] = '1'
-
# skia_use_android_framework_defines.
if builder_dict.get('extra_config') == 'Android_FrameworkDefs':
gyp_defs['skia_use_android_framework_defines'] = '1'
@@ -163,6 +159,11 @@ def get_extra_env_vars(builder_dict):
env['CC'] = '/usr/bin/clang'
env['CXX'] = '/usr/bin/clang++'
+ # SKNX_NO_SIMD, SK_USE_DISCARDABLE_SCALEDIMAGECACHE, etc.
+ extra_config = builder_dict.get('extra_config', '')
+ if extra_config.startswith('SK') and extra_config.isupper():
+ env['CPPFLAGS'] = '-D' + extra_config
+
return env
« no previous file with comments | « tools/buildbot_spec.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698