Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1346833003: Lazy init prefs in MD Settings (Closed)

Created:
5 years, 3 months ago by michaelpg
Modified:
5 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Lazy init prefs in MD Settings Committed: https://crrev.com/15c791b687c594017b012a8f1407debeacba1300 Cr-Commit-Position: refs/heads/master@{#349192}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -33 lines) Patch
M chrome/browser/resources/settings/checkbox/checkbox.js View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/resources/settings/prefs/prefs.js View 3 chunks +12 lines, -28 lines 0 comments Download

Dependent Patchsets:

Issue 1310843010 Patch 260001

Messages

Total messages: 9 (3 generated)
Dan Beam
lgtm but you wont be able to do this in all cases
5 years, 3 months ago (2015-09-16 04:46:04 UTC) #3
michaelpg
On 2015/09/16 04:46:04, Dan Beam wrote: > lgtm but you wont be able to do ...
5 years, 3 months ago (2015-09-16 04:49:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346833003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346833003/20001
5 years, 3 months ago (2015-09-16 18:16:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 3 months ago (2015-09-16 19:31:23 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/15c791b687c594017b012a8f1407debeacba1300 Cr-Commit-Position: refs/heads/master@{#349192}
5 years, 3 months ago (2015-09-16 19:32:38 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:59:22 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/15c791b687c594017b012a8f1407debeacba1300
Cr-Commit-Position: refs/heads/master@{#349192}

Powered by Google App Engine
This is Rietveld 408576698