chrome/browser/resources/settings/checkbox/checkbox.js - Issue 1346833003: Lazy init prefs in MD Settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/checkbox/checkbox.js

Issue 1346833003: Lazy init prefs in MD Settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/checkbox/checkbox.js

diff --git a/chrome/browser/resources/settings/checkbox/checkbox.js b/chrome/browser/resources/settings/checkbox/checkbox.js

index 2109aba704b116f176e0fb79a4e7f9dc2c25dd2f..d8c1a1f2ededd0b2ea0ec83aa6748a159471f085 100644

--- a/chrome/browser/resources/settings/checkbox/checkbox.js

+++ b/chrome/browser/resources/settings/checkbox/checkbox.js

@@ -24,7 +24,6 @@ Polymer({

pref: {

type: Object,

notify: true,

- value: null

inverted: {

@@ -60,10 +59,7 @@ Polymer({

/** @private */

prefValueChanged_: function(prefValue) {

- // prefValue is initially undefined when Polymer initializes pref.

- if (prefValue !== undefined) {

- this.checked = this.getNewValue_(prefValue);

- }

+ this.checked = this.getNewValue_(prefValue);

/** @private */

« no previous file with comments | « no previous file | chrome/browser/resources/settings/prefs/prefs.js » ('j') | no next file with comments »