Make marking a reftests as NeedsRebaseline/NeedsManualRebaseline a lint error.

Make marking a reftests as NeedsRebaseline/NeedsManualRebaseline a lint error.

There's no way to rebaseline reftests. So, error on the linter instead of
after people have committed the patch and the auto-rebaseline runs.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165013

[Dirk Pranke, 2014-01-13 21:53:45]

lgtm.

https://codereview.chromium.org/134663004/diff/1/Tools/Scripts/webkitpy/layou...
File Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py
(right):

https://codereview.chromium.org/134663004/diff/1/Tools/Scripts/webkitpy/layou...
Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:193:
self.assertEqual(str(e), warnings)
looks like there's a bunch of boilerplate in this test (and the next one, and
probably others) that could be simplified w/ a helper mode to write tests and a
helper method to check that warnings are raised (e.g., modify
assert_bad_expectations() to take an option warning to match against).

Feel free to fix that, add a FIXME, or do nothing at all.

[commit-bot: I haz the power, 2014-01-13 22:05:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ojan@chromium.org/134663004/1

[commit-bot: I haz the power, 2014-01-14 00:30:51]

Change committed as 165013