Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py - Issue 134663004: Make marking a reftests as NeedsRebaseline/NeedsManualRebaseline a lint error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py

Issue 134663004: Make marking a reftests as NeedsRebaseline/NeedsManualRebaseline a lint error. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py » ('j') | Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py b/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py

index eeb4a94980907f9bb0ed40b89e66eeabfbc8a6ac..861720c9f922849da59e0d7f328532c3ed2a1917 100644

--- a/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py

+++ b/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py

@@ -156,6 +156,11 @@ class TestExpectationParser(object):

if self.REBASELINE_MODIFIER in expectations:

expectation_line.warnings.append('REBASELINE should only be used for running rebaseline.py. Cannot be checked in.')

+ if self.NEEDS_REBASELINE_MODIFIER in expectations or self.NEEDS_MANUAL_REBASELINE_MODIFIER in expectations:

+ for test in expectation_line.matching_tests:

+ if self._port.reference_files(test):

+ expectation_line.warnings.append('A reftest cannot be marked as NeedsRebaseline/NeedsManualRebaseline')

def _parse_expectations(self, expectation_line):

result = set()

for part in expectation_line.expectations: