Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1346623002: MIPS: Fixing floating point register clobbering (Closed)

Created:
5 years, 3 months ago by ivica.bogosavljevic
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fixing floating point register clobbering Fixing floating point register clobbering for MIPSr6 (32 and 64) due to using of f31 floating point register as double compare register, without saving the value of the register before using it. TEST=cctest/test-debug/* BUG= Committed: https://crrev.com/2d8d02f5558386438c3765146edecf5c5706fba3 Cr-Commit-Position: refs/heads/master@{#30765}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/mips/assembler-mips.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips64/assembler-mips64.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
paul.l...
LGTM.
5 years, 3 months ago (2015-09-15 14:24:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346623002/1
5 years, 3 months ago (2015-09-16 08:02:49 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/7870)
5 years, 3 months ago (2015-09-16 08:04:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346623002/1
5 years, 3 months ago (2015-09-16 11:49:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-16 12:15:20 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-16 12:15:41 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d8d02f5558386438c3765146edecf5c5706fba3
Cr-Commit-Position: refs/heads/master@{#30765}

Powered by Google App Engine
This is Rietveld 408576698