Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(23)

Issue 13465009: Merge 147127 "RenderBox::backgroundIsKnownToBeOpaqueInRect may b..." (Closed)

Created:
7 years, 8 months ago by alokp
Modified:
7 years, 8 months ago
Reviewers:
alokp
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1453/
Visibility:
Public.

Description

Merge 147127 "RenderBox::backgroundIsKnownToBeOpaqueInRect may b..." > RenderBox::backgroundIsKnownToBeOpaqueInRect may be wrong for theme-painted elements > https://bugs.webkit.org/show_bug.cgi?id=113419 > > Reviewed by Simon Fraser. > > Source/WebCore: > > Do not consider control elements as opaque. They are typically theme painted, and we cannot assume opaqueness on the behalf of theme. It can be improved by asking the theme if it paints opaque. > > Test: compositing/contents-opaque/control-layer.html > > * rendering/RenderBox.cpp: > (WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect): > > LayoutTests: > > * compositing/contents-opaque/control-layer-expected.txt: Added. > * compositing/contents-opaque/control-layer.html: Added. > * platform/chromium/compositing/contents-opaque/control-layer-expected.txt: Added. TBR=alokp@chromium.org BUG=223490 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147448

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, --3 lines) Patch
A + LayoutTests/compositing/contents-opaque/control-layer.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/compositing/contents-opaque/control-layer-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/chromium/compositing/contents-opaque/control-layer-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/rendering/RenderBox.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
alokp
7 years, 8 months ago (2013-04-02 17:39:10 UTC) #1
alokp
7 years, 8 months ago (2013-04-02 17:39:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r147448.

Powered by Google App Engine
This is Rietveld 408576698