Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: Source/WebCore/rendering/RenderBox.cpp

Issue 13465009: Merge 147127 "RenderBox::backgroundIsKnownToBeOpaqueInRect may b..." (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1453/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/platform/chromium/compositing/contents-opaque/control-layer-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/rendering/RenderBox.cpp
===================================================================
--- Source/WebCore/rendering/RenderBox.cpp (revision 147447)
+++ Source/WebCore/rendering/RenderBox.cpp (working copy)
@@ -1171,6 +1171,12 @@
if (!backgroundColor.isValid() || backgroundColor.hasAlpha())
return false;
+ // If the element has appearance, it might be painted by theme.
+ // We cannot be sure if theme paints the background opaque.
+ // In this case it is safe to not assume opaqueness.
+ // FIXME: May be ask theme if it paints opaque.
+ if (style()->hasAppearance())
+ return false;
// FIXME: Check the opaqueness of background images.
// FIXME: Use rounded rect if border radius is present.
« no previous file with comments | « LayoutTests/platform/chromium/compositing/contents-opaque/control-layer-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698