Source/WebCore/page/scrolling/ScrollingCoordinator.cpp - Issue 13462003: Add support for accelerated fixed root background

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/page/scrolling/ScrollingCoordinator.cpp

Issue 13462003: Add support for accelerated fixed root background (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@background-attachment-fixed2

Patch Set: Adding a FIXME for a bit that'll need fixing. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/WebCore/page/FrameView.cpp ('K') | « Source/WebCore/page/scrolling/ScrollingCoordinator.h ('k') | Source/WebCore/rendering/RenderLayerBacking.cpp » ('j') | Source/WebCore/rendering/RenderLayerCompositor.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/page/scrolling/ScrollingCoordinator.cpp

diff --git a/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp b/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp

index b0fe6878aebcef7a337ecd758ca4540aea95367a..b2dc39baa9cac4a137fc508ce47b68db1237ab34 100644

--- a/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp

+++ b/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp

@@ -122,6 +122,12 @@ void ScrollingCoordinator::frameViewLayoutUpdated(FrameView* frameView)

scrollLayer->setBounds(frameView->contentsSize());

}

+void ScrollingCoordinator::fixedRootBackgroundLayerDidChange(GraphicsLayer* backgroundLayer)

+ if (WebLayer* webBackgroundLayer = scrollingWebLayerForGraphicsLayer(backgroundLayer))

+ webBackgroundLayer->setPositionConstraint(WebLayerPositionConstraint::fixedPosition(false, false));

void ScrollingCoordinator::setLayerIsContainerForFixedPositionLayers(GraphicsLayer* layer, bool enable)

{

if (WebLayer* scrollableLayer = scrollingWebLayerForGraphicsLayer(layer))