Source/WebCore/page/FrameView.cpp - Issue 13462003: Add support for accelerated fixed root background

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/page/FrameView.cpp

Issue 13462003: Add support for accelerated fixed root background (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@background-attachment-fixed2

Patch Set: Adding a FIXME for a bit that'll need fixing. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/WebCore/page/FrameView.cpp

diff --git a/Source/WebCore/page/FrameView.cpp b/Source/WebCore/page/FrameView.cpp

index 485bd41868a374c6d5ceac2fb9994fbfa0017706..a6fcbb95fbc596e63296242383cf04773a5034b4 100644

--- a/Source/WebCore/page/FrameView.cpp

+++ b/Source/WebCore/page/FrameView.cpp

@@ -195,6 +195,7 @@ FrameView::FrameView(Frame* frame)

, m_shouldAutoSize(false)

, m_inAutoSize(false)

, m_didRunAutosize(false)

+ , m_hasFixedRootBackgroundLayer(false)

, m_headerHeight(0)

, m_footerHeight(0)

#if ENABLE(CSS_FILTERS)

@@ -2004,7 +2005,7 @@ void FrameView::updateFixedElementsAfterScrolling()

if (!shouldUpdateFixedElementsAfterScrolling())

return;

- if (m_nestedLayoutCount <= 1 && hasViewportConstrainedObjects()) {

+ if (m_nestedLayoutCount <= 1 && (hasViewportConstrainedObjects() || hasFixedRootBackgroundLayer())) {

jamesr 2013/04/09 19:45:48 why do you need to updateCompositingLayers() on sc

if (RenderView* renderView = this->renderView())

renderView->compositor()->updateCompositingLayers(CompositingUpdateOnScroll);

}

« no previous file with comments | « Source/WebCore/page/FrameView.h ('k') | Source/WebCore/page/Settings.h » ('j') | Source/WebCore/rendering/RenderLayerCompositor.cpp » ('J')