Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1346143004: Don't use resolved url for instance identity in ApplicationManager (Closed)

Created:
5 years, 3 months ago by Ben Goodger (Google)
Modified:
5 years, 3 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use resolved url for instance identity in ApplicationManager R=yzshen@chromium.org http://crbug.com/533085 Committed: https://crrev.com/ce9f95edbf5b420aa0f7b0a522112751b547d215 Cr-Commit-Position: refs/heads/master@{#349541} Committed: https://crrev.com/79341ad47c83799fbb10382c9599eeaa781f3620 Cr-Commit-Position: refs/heads/master@{#349608}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -85 lines) Patch
M mojo/package_manager/package_manager_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/package_manager/package_manager_impl.cc View 1 2 5 chunks +7 lines, -8 lines 0 comments Download
M mojo/shell/application_manager.h View 1 1 chunk +0 lines, -8 lines 0 comments Download
M mojo/shell/application_manager.cc View 1 2 3 4 chunks +9 lines, -40 lines 0 comments Download
M mojo/shell/application_manager_unittest.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M mojo/shell/package_manager.h View 4 chunks +4 lines, -10 lines 0 comments Download
M mojo/shell/test_package_manager.h View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/shell/test_package_manager.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Ben Goodger (Google)
5 years, 3 months ago (2015-09-17 22:28:10 UTC) #2
yzshen1
So happy to see this change. :) LGTM https://codereview.chromium.org/1346143004/diff/40001/mojo/shell/application_manager.cc File mojo/shell/application_manager.cc (right): https://codereview.chromium.org/1346143004/diff/40001/mojo/shell/application_manager.cc#newcode85 mojo/shell/application_manager.cc:85: // ...
5 years, 3 months ago (2015-09-17 22:38:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346143004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346143004/60001
5 years, 3 months ago (2015-09-17 22:41:42 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-17 23:41:07 UTC) #7
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/ce9f95edbf5b420aa0f7b0a522112751b547d215 Cr-Commit-Position: refs/heads/master@{#349541}
5 years, 3 months ago (2015-09-17 23:41:40 UTC) #8
Justin Donnelly
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1354813002/ by jdonnelly@chromium.org. ...
5 years, 3 months ago (2015-09-18 00:42:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346143004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346143004/80001
5 years, 3 months ago (2015-09-18 02:57:58 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 3 months ago (2015-09-18 03:59:43 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 04:00:07 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/79341ad47c83799fbb10382c9599eeaa781f3620
Cr-Commit-Position: refs/heads/master@{#349608}

Powered by Google App Engine
This is Rietveld 408576698