Don't use resolved url for instance identity in ApplicationManager

mojo/package_manager/package_manager_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/package_manager/package_manager_impl.h"
 
 #include "mojo/fetcher/about_fetcher.h"
 #include "mojo/fetcher/data_fetcher.h"
 #include "mojo/fetcher/local_fetcher.h"
 #include "mojo/fetcher/network_fetcher.h"
@@ skipping 38 matching lines @@
     const std::string& qualifier) {
   application_package_alias_[alias] =
       std::make_pair(content_handler_package, qualifier);
 }
 
 void PackageManagerImpl::SetApplicationManager(
     shell::ApplicationManager* manager) {
   application_manager_ = manager;
 }
 
-GURL PackageManagerImpl::ResolveURL(const GURL& url) {
-  return url_resolver_.get() ? url_resolver_->ResolveMojoURL(url) : url;
-}
-
 void PackageManagerImpl::FetchRequest(
     URLRequestPtr request,
     const shell::Fetcher::FetchCallback& loader_callback) {
   GURL url(request->url);
   if (url.SchemeIs(fetcher::AboutFetcher::kAboutScheme)) {
     fetcher::AboutFetcher::Start(url, loader_callback);
     return;
   }
 
   if (url.SchemeIs(url::kDataScheme)) {
     fetcher::DataFetcher::Start(url, loader_callback);
     return;
   }
 
   GURL resolved_url = ResolveURL(url);
-
   if (resolved_url.SchemeIsFile()) {
     // LocalFetcher uses the network service to infer MIME types from URLs.
     // Skip this for mojo URLs to avoid recursively loading the network service.
     if (!network_service_ && !url.SchemeIs("mojo")) {
       shell::ConnectToService(application_manager_,
                               GURL("mojo:network_service"), &network_service_);
     }
     // Ownership of this object is transferred to |loader_callback|.
     // TODO(beng): this is eff'n weird.
     new fetcher::LocalFetcher(
@@ skipping 25 matching lines @@
                             &url_loader_factory_);
   }
 
   // Ownership of this object is transferred to |loader_callback|.
   // TODO(beng): this is eff'n weird.
   new fetcher::NetworkFetcher(disable_cache_, request.Pass(),
                               url_loader_factory_.get(), loader_callback);
 }
 
 bool PackageManagerImpl::HandleWithContentHandler(shell::Fetcher* fetcher,
-                                                  const GURL& unresolved_url,
+                                                  const GURL& url,
                                                   base::TaskRunner* task_runner,
                                                   URLResponsePtr* new_response,
                                                   GURL* content_handler_url,
                                                   std::string* qualifier) {
   // TODO(beng): it seems like some delegate should/would want to have a say in
   //             configuring the qualifier also.
   bool enable_multi_process = base::CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kEnableMultiprocess);
 
   // The response begins with a #!mojo <content-handler-url>.
@@ skipping 10 matching lines @@
   MimeTypeToURLMap::iterator iter = mime_type_to_url_.find(fetcher->MimeType());
   if (iter != mime_type_to_url_.end()) {
     *new_response = fetcher->AsURLResponse(task_runner, 0);
     *content_handler_url = iter->second;
     *qualifier = enable_multi_process ? (*new_response)->site.To<std::string>()
                                       : std::string();
     return true;
   }
 
   // The response URL matches a registered content handler.
-  auto alias_iter = application_package_alias_.find(unresolved_url);
+  auto alias_iter = application_package_alias_.find(url);
   if (alias_iter != application_package_alias_.end()) {
     // We replace the qualifier with the one our package alias requested.
     *new_response = URLResponse::New();
-    (*new_response)->url = unresolved_url.spec();
+    (*new_response)->url = url.spec();
 
     // Why can't we use this in single process mode? Because of
     // base::AtExitManager. If you link in ApplicationRunner into your code, and
     // then we make initialize multiple copies of the application, we end up
     // with multiple AtExitManagers and will check on the second one being
     // created.
     //
     // Why doesn't that happen when running different apps? Because
     // your_thing.mojo!base::AtExitManager and
     // my_thing.mojo!base::AtExitManager are different symbols.
     *qualifier = enable_multi_process ? alias_iter->second.second
                                       : std::string();
     *content_handler_url = alias_iter->second.first;
     return true;
   }
 
   return false;
 }
 
+GURL PackageManagerImpl::ResolveURL(const GURL& url) {
+  return url_resolver_.get() ? url_resolver_->ResolveMojoURL(url) : url;
+}
+
 }  // namespace package_manager
 }  // namespace mojo