Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1346133004: Remove SpdySession::GetSSLClientSocket (Closed)

Created:
5 years, 3 months ago by Paritosh Kumar
Modified:
5 years, 3 months ago
Reviewers:
Ryan Hamilton, davidben
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SpdySession::GetSSLClientSocket After removing SpdyStream::GetSSLCertRequestInfo, in https://codereview.chromium.org/1128873008, this method looks like unused. BUG= Committed: https://crrev.com/1491e143c78f1cd6f69821110276c61f41596a5e Cr-Commit-Position: refs/heads/master@{#349697}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M net/spdy/spdy_session.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/spdy/spdy_session.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Paritosh Kumar
Please have a look.
5 years, 3 months ago (2015-09-18 11:54:18 UTC) #2
Ryan Hamilton
lgtm
5 years, 3 months ago (2015-09-18 14:22:07 UTC) #3
davidben
lgtm
5 years, 3 months ago (2015-09-18 15:36:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346133004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346133004/1
5 years, 3 months ago (2015-09-18 15:48:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 17:05:03 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 17:05:38 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1491e143c78f1cd6f69821110276c61f41596a5e
Cr-Commit-Position: refs/heads/master@{#349697}

Powered by Google App Engine
This is Rietveld 408576698