Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1128873008: Remove SpdyStream::GetSSLCertRequestInfo. (Closed)

Created:
5 years, 7 months ago by davidben
Modified:
5 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@opt-in-renego
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SpdyStream::GetSSLCertRequestInfo. SPDY's multiplexing is incompatible with the renego + client auth hack. The old implementation also assumed that the SpdyStream was still alive which isn't true. We could attempt save a copy of it, but that doesn't resolve the fundamental incompatibility of the hack. Instead https://codereview.chromium.org/1131763002/ disables renegotiation, so this codepath should be impossible. BUG=462283 Committed: https://crrev.com/b38fe83bd9f34f101e705bff5397c9530b024edd Cr-Commit-Position: refs/heads/master@{#329493}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -23 lines) Patch
M net/spdy/spdy_http_stream.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/spdy/spdy_session.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/spdy/spdy_session.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M net/spdy/spdy_stream.h View 2 chunks +0 lines, -5 lines 0 comments Download
M net/spdy/spdy_stream.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
This depends on the linked CL, otherwise the NOTREACHED is a lie.
5 years, 7 months ago (2015-05-06 23:55:57 UTC) #2
Ryan Hamilton
AWESOME! LGTM
5 years, 7 months ago (2015-05-07 23:40:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128873008/1
5 years, 7 months ago (2015-05-12 20:58:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 21:26:14 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 21:26:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b38fe83bd9f34f101e705bff5397c9530b024edd
Cr-Commit-Position: refs/heads/master@{#329493}

Powered by Google App Engine
This is Rietveld 408576698