Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1346113003: Mandoline: WebGL: Pass context creation attributes to GPU. (Closed)

Created:
5 years, 3 months ago by Peng
Modified:
5 years, 3 months ago
Reviewers:
jam, sky, piman
CC:
chromium-reviews, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mandoline: WebGL: Pass context creation attributes to GPU. TEST=mandoline http://www.yuichiroharai.com/wgl/ BUG=525159 Committed: https://crrev.com/fdb4e6032a9703b86b6c186ffd34422a1827b178 Cr-Commit-Position: refs/heads/master@{#349422}

Patch Set 1 #

Patch Set 2 : WIP #

Patch Set 3 : WIP #

Patch Set 4 : Update #

Patch Set 5 : Update #

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -18 lines) Patch
M components/html_viewer/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M components/html_viewer/DEPS View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc View 2 chunks +15 lines, -1 line 0 comments Download
M components/mus/gles2/command_buffer_driver.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M components/mus/gles2/command_buffer_driver.cc View 1 2 3 4 4 chunks +11 lines, -5 lines 0 comments Download
M components/mus/gles2/command_buffer_impl.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/gles2/command_buffer_impl.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M components/mus/public/interfaces/command_buffer.mojom View 1 1 chunk +2 lines, -1 line 0 comments Download
M components/pdf_viewer/pdf_viewer.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M mojo/cc/context_provider_mojo.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.h View 3 chunks +3 lines, -0 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.cc View 2 chunks +4 lines, -1 line 0 comments Download
M mojo/gles2/gles2_context.h View 2 chunks +4 lines, -1 line 0 comments Download
M mojo/gles2/gles2_context.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M mojo/gles2/gles2_impl.cc View 1 2 2 chunks +12 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/c/gles2/gles2.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/platform/native/gles2_thunks.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/platform/native/gles2_thunks.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 26 (11 generated)
Peng
Hi piman, Could you please take a look? Thanks.
5 years, 3 months ago (2015-09-16 19:17:50 UTC) #2
piman
lgtm
5 years, 3 months ago (2015-09-16 20:08:52 UTC) #3
Peng
Hi Scott, Could you please take a look? Thanks.
5 years, 3 months ago (2015-09-16 20:21:08 UTC) #5
sky
LGTM
5 years, 3 months ago (2015-09-16 21:56:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346113003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346113003/80001
5 years, 3 months ago (2015-09-17 01:18:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/100786)
5 years, 3 months ago (2015-09-17 01:31:19 UTC) #10
Peng
+jam OWNERS for pdf viewer. PTAL. Thanks.
5 years, 3 months ago (2015-09-17 01:36:12 UTC) #12
jam
lgtm
5 years, 3 months ago (2015-09-17 14:48:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346113003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346113003/80001
5 years, 3 months ago (2015-09-17 14:48:53 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/100999)
5 years, 3 months ago (2015-09-17 14:49:49 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346113003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346113003/80001
5 years, 3 months ago (2015-09-17 14:52:12 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/101001)
5 years, 3 months ago (2015-09-17 14:53:20 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346113003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346113003/100001
5 years, 3 months ago (2015-09-17 15:08:55 UTC) #24
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 3 months ago (2015-09-17 15:39:19 UTC) #25
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 15:39:54 UTC) #26
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/fdb4e6032a9703b86b6c186ffd34422a1827b178
Cr-Commit-Position: refs/heads/master@{#349422}

Powered by Google App Engine
This is Rietveld 408576698