Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1345853005: Move determiniation of strokerect rects internal (Closed)

Created:
5 years, 3 months ago by joshua.litt
Modified:
5 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@strokerectfix
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move determiniation of strokerect rects internal BUG=skia: Committed: https://skia.googlesource.com/skia/+/10cae83e4bb726610b93276e17815c5d52d73395

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : cleanup #

Total comments: 4

Patch Set 4 : comment fixed #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -85 lines) Patch
M src/gpu/GrDrawContext.cpp View 2 1 chunk +3 lines, -4 lines 0 comments Download
M src/gpu/batches/GrAAStrokeRectBatch.h View 2 2 chunks +8 lines, -5 lines 0 comments Download
M src/gpu/batches/GrAAStrokeRectBatch.cpp View 1 2 3 2 chunks +89 lines, -7 lines 1 comment Download
M src/gpu/batches/GrRectBatchFactory.h View 2 2 chunks +7 lines, -5 lines 0 comments Download
M src/gpu/batches/GrRectBatchFactory.cpp View 2 1 chunk +0 lines, -64 lines 0 comments Download

Depends on Patchset:

Issue 1359453002 Patch 130001

Dependent Patchsets:

Issue 1336413006 Patch 60001
Issue 1355353002 Patch 1
Issue 1355353002 Patch 20001
Issue 1355353002 Patch 40001
Issue 1355353002 Patch 60001

Messages

Total messages: 8 (2 generated)
joshualitt
A straightforward patch, ptal
5 years, 3 months ago (2015-09-22 17:12:17 UTC) #2
robertphillips
https://codereview.chromium.org/1345853005/diff/40001/src/gpu/batches/GrAAStrokeRectBatch.cpp File src/gpu/batches/GrAAStrokeRectBatch.cpp (right): https://codereview.chromium.org/1345853005/diff/40001/src/gpu/batches/GrAAStrokeRectBatch.cpp#newcode576 src/gpu/batches/GrAAStrokeRectBatch.cpp:576: // For bevel-stroke, use 2 SkRect instances(devOutside and devOutsideAssist) ...
5 years, 3 months ago (2015-09-22 17:35:47 UTC) #3
joshualitt
feedback inc https://codereview.chromium.org/1345853005/diff/40001/src/gpu/batches/GrAAStrokeRectBatch.cpp File src/gpu/batches/GrAAStrokeRectBatch.cpp (right): https://codereview.chromium.org/1345853005/diff/40001/src/gpu/batches/GrAAStrokeRectBatch.cpp#newcode576 src/gpu/batches/GrAAStrokeRectBatch.cpp:576: // For bevel-stroke, use 2 SkRect instances(devOutside ...
5 years, 3 months ago (2015-09-22 17:44:54 UTC) #4
robertphillips
lgtm https://codereview.chromium.org/1345853005/diff/60001/src/gpu/batches/GrAAStrokeRectBatch.cpp File src/gpu/batches/GrAAStrokeRectBatch.cpp (right): https://codereview.chromium.org/1345853005/diff/60001/src/gpu/batches/GrAAStrokeRectBatch.cpp#newcode629 src/gpu/batches/GrAAStrokeRectBatch.cpp:629: It is too bad we can't compute all ...
5 years, 3 months ago (2015-09-22 17:55:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345853005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345853005/60001
5 years, 3 months ago (2015-09-22 19:45:26 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 19:50:39 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/10cae83e4bb726610b93276e17815c5d52d73395

Powered by Google App Engine
This is Rietveld 408576698