Issue 1336413006: Just an experiment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1336413006: Just an experiment (Closed)

Created:
5 years, 3 months ago by joshua.litt

Modified:
5 years, 3 months ago

Reviewers:
joshualitt, bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Just an experiment BUG=skia:

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : saving #

Patch Set 4 : tweaks #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+432 lines, -30 lines)			Patch
M	gyp/gpu.gypi	View	1 2 3	1 chunk	+6 lines, -0 lines	0 comments	Download
M	include/gpu/GrDrawContext.h	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/gpu/GrDrawContext.cpp	View	1 2 3	3 chunks	+9 lines, -1 line	0 comments	Download
M	src/gpu/GrDrawTarget.h	View	1 2 3	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/gpu/GrDrawTarget.cpp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/gpu/SkGpuDevice.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	1 2	4 chunks	+7 lines, -11 lines	0 comments	Download
M	src/gpu/batches/GrAAFillRectBatch.h	View	1 2 3	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/gpu/batches/GrAAFillRectBatch.cpp	View	1 2 3	3 chunks	+11 lines, -6 lines	0 comments	Download
M	src/gpu/batches/GrBatch.h	View	1 2 3	3 chunks	+11 lines, -0 lines	0 comments	Download
M	src/gpu/batches/GrNonAAFillRectBatch.h	View	1 2 3	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/gpu/batches/GrNonAAStrokeRectBatch.h	View	1 2 3	2 chunks	+4 lines, -1 line	0 comments	Download
M	src/gpu/batches/GrRectBatchFactory.h	View	1 2 3	3 chunks	+13 lines, -4 lines	0 comments	Download
A	src/gpu/draws/GrDraw.h	View	1 2 3	1 chunk	+74 lines, -0 lines	0 comments	Download
A +	src/gpu/draws/GrDraw.cpp	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
A	src/gpu/draws/GrDrawRect.h	View	1 2 3	1 chunk	+58 lines, -0 lines	0 comments	Download
A	src/gpu/draws/GrDrawRect.cpp	View	1 2 3	1 chunk	+215 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 1345853005 Patch 60001

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

bsalomon

5 years, 3 months ago (2015-09-15 20:39:22 UTC) #3

On 2015/09/15 15:32:29, joshualitt wrote:
> ptal

Seems like a good starting point. As we discussed, I think the longer-lived
thing that gets stored on the batch/pipeline should probably be a different
type.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages