Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1345833003: Revert of Invalidate whitespace text on text color changes (Closed)

Created:
5 years, 3 months ago by pdr.
Modified:
5 years, 3 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Invalidate whitespace text on text color changes (patchset #3 id:40001 of https://codereview.chromium.org/1332233002/ ) Reason for revert: Caused a perf regression on https://chromeperf.appspot.com/report?sid=853c237ff4d1aba523371425b1de88bf28b30ae72464c956409b9a5874a5afd2 Original issue's description: > Invalidate whitespace text on text color changes > > This patch updates the optimization added in [1] to invalidate > whitespace text on color changes because whitespace text can have > decorations such as underlines which still need to repaint. > > The big idea of the optimization in [1] is to not unnecessarily repaint > expensive items such as images that are in an <a> element. On hover, <a> > will change color and underline styles which should not affect images. > This patch adds a test to prove this optimization still works and > prevents it from breaking in the future. > > [1] https://src.chromium.org/viewvc/blink?view=rev&revision=152046 > > BUG=529944 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202164 TBR=chrishtr@chromium.org BUG=529944 Committed: https://crrev.com/7517302b3b6236a9c25f26d345d2a990b01dc636 git-svn-id: svn://svn.chromium.org/blink/trunk@202374 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -128 lines) Patch
M LayoutTests/fast/repaint/inline-outline-repaint-2-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
D LayoutTests/paint/invalidation/non-text-link-invalidation-optimization.html View 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/paint/invalidation/non-text-link-invalidation-optimization-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
M LayoutTests/paint/invalidation/spv2/inline-outline-repaint-2.html View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/paint/invalidation/text-decoration-invalidation.html View 1 chunk +0 lines, -36 lines 0 comments Download
D LayoutTests/paint/invalidation/text-decoration-invalidation-expected.html View 1 chunk +0 lines, -19 lines 0 comments Download
M Source/core/layout/LayoutObject.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/style/ComputedStyle.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/style/StyleDifference.h View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
pdr.
Created Revert of Invalidate whitespace text on text color changes
5 years, 3 months ago (2015-09-15 19:54:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345833003/1
5 years, 3 months ago (2015-09-15 19:54:48 UTC) #2
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 3 months ago (2015-09-15 19:55:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345833003/170001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345833003/170001
5 years, 3 months ago (2015-09-16 03:14:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/107738)
5 years, 3 months ago (2015-09-16 07:57:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345833003/170001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345833003/170001
5 years, 3 months ago (2015-09-16 18:09:30 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:170001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202374
5 years, 3 months ago (2015-09-16 19:14:52 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:58:59 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7517302b3b6236a9c25f26d345d2a990b01dc636

Powered by Google App Engine
This is Rietveld 408576698