Source/core/layout/LayoutObject.cpp - Issue 1345833003: Revert of Invalidate whitespace text on text color changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutObject.cpp

Issue 1345833003: Revert of Invalidate whitespace text on text color changes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/paint/invalidation/text-decoration-invalidation-expected.html ('k') | Source/core/style/ComputedStyle.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/LayoutObject.cpp

diff --git a/Source/core/layout/LayoutObject.cpp b/Source/core/layout/LayoutObject.cpp

index fbbacec8a7723138ba3d3942468683efbd95b6df..40174392dbd2e3a08896a7b05b0d865e39921b22 100644

--- a/Source/core/layout/LayoutObject.cpp

+++ b/Source/core/layout/LayoutObject.cpp

@@ -1717,10 +1717,10 @@ StyleDifference LayoutObject::adjustStyleDifference(StyleDifference diff) const

diff.setNeedsPaintInvalidationLayer();

}

- if (diff.textDecorationOrColorChanged() && !diff.needsPaintInvalidation()) {

+ if (diff.textOrColorChanged() && !diff.needsPaintInvalidation()) {

if (style()->hasBorder() || style()->hasOutline()

|| style()->isBackgroundColorCurrentColor()

- || (isText() && !isBR()))

+ || (isText() && !toLayoutText(this)->isAllCollapsibleWhitespace()))

diff.setNeedsPaintInvalidationObject();

}

« no previous file with comments | « LayoutTests/paint/invalidation/text-decoration-invalidation-expected.html ('k') | Source/core/style/ComputedStyle.cpp » ('j') | no next file with comments »