Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 134583002: Add "prodchannel" attribute in component updater update requests. (Closed)

Created:
6 years, 11 months ago by waffles
Modified:
6 years, 11 months ago
Reviewers:
Sorin Jianu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add "prodchannel" attribute in component updater update requests. In order to be compatible with the version 2 of the update protocol and existing config files, we need to serialize "prodchannel" as part of the <request> element; "updaterchannel" is not enough (though it is also required for logging via the version 3 protocol). BUG=332551 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244364

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M chrome/browser/component_updater/component_updater_utils.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/component_updater/test/component_updater_service_unittest.cc View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
waffles
Hi Sorin, please take a look at this short CL to add prodchannel. I also ...
6 years, 11 months ago (2014-01-10 19:10:28 UTC) #1
Sorin Jianu
lgtm Thank you!
6 years, 11 months ago (2014-01-10 20:47:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/waffles@chromium.org/134583002/1
6 years, 11 months ago (2014-01-10 20:55:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/waffles@chromium.org/134583002/1
6 years, 11 months ago (2014-01-10 23:53:02 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-11 22:25:53 UTC) #5
Message was sent while issue was closed.
Change committed as 244364

Powered by Google App Engine
This is Rietveld 408576698