Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Unified Diff: chrome/browser/component_updater/test/component_updater_service_unittest.cc

Issue 134583002: Add "prodchannel" attribute in component updater update requests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/component_updater/component_updater_utils.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/component_updater/test/component_updater_service_unittest.cc
diff --git a/chrome/browser/component_updater/test/component_updater_service_unittest.cc b/chrome/browser/component_updater/test/component_updater_service_unittest.cc
index 99a7acb32b6cffa5b093f29d39882df28b938813..614f1b00fbd925588613d3aac91648a21d337692 100644
--- a/chrome/browser/component_updater/test/component_updater_service_unittest.cc
+++ b/chrome/browser/component_updater/test/component_updater_service_unittest.cc
@@ -476,16 +476,19 @@ TEST_F(ComponentUpdaterTest, InstallCrx) {
// are important for backward compatibility with the version v2 of the update
// protocol. In this case, inspect the <request>, which is the first element
// after the xml declaration of the update request body.
- // Expect to find the |os| and the |arch| attributes:
+ // Expect to find the |os|, |arch|, |prodchannel|, and |prodversion|
+ // attributes:
// <?xml version="1.0" encoding="UTF-8"?>
- // <request...os=...arch=...>
+ // <request... os=... arch=... prodchannel=... prodversion=...>
// ...
// </request>
const std::string update_request(post_interceptor_->GetRequests()[0]);
std::vector<base::StringPiece> elements;
Tokenize(update_request, "<>", &elements);
- EXPECT_NE(string::npos, elements[1].find("os="));
- EXPECT_NE(string::npos, elements[1].find("arch="));
+ EXPECT_NE(string::npos, elements[1].find(" os="));
+ EXPECT_NE(string::npos, elements[1].find(" arch="));
+ EXPECT_NE(string::npos, elements[1].find(" prodchannel="));
+ EXPECT_NE(string::npos, elements[1].find(" prodversion="));
component_updater()->Stop();
}
« no previous file with comments | « chrome/browser/component_updater/component_updater_utils.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698