Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 13458002: Use sequenced workers for the getting the system's font list. (Closed)

Created:
7 years, 8 months ago by falken
Modified:
7 years, 8 months ago
Reviewers:
brettw, raymes
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, behdad
Visibility:
Public.

Description

Use sequenced workers for the getting the system's font list. This is necessary because on Linux we use Pango, which is not threadsafe (only newer versions are). BUG=223772 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192307

Patch Set 1 #

Patch Set 2 : use sequenced workers #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -10 lines) Patch
M content/browser/font_list_async.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_browser_font_singleton_host.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_truetype_font_list_host.cc View 1 2 chunks +7 lines, -3 lines 0 comments Download
M content/common/font_list.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
A + content/common/font_list.cc View 1 1 chunk +5 lines, -3 lines 1 comment Download
M content/content_common.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
falken
brettw: Can you please review? behdad: CC'ing in case you have comments
7 years, 8 months ago (2013-04-02 08:18:36 UTC) #1
brettw
This is being called on the blocking pool which uses different threads. Your patch will ...
7 years, 8 months ago (2013-04-02 18:07:57 UTC) #2
falken
brettw: Thanks. Please take another look. raymes: Please review as pepper OWNER https://codereview.chromium.org/13458002/diff/13001/content/common/font_list.cc File content/common/font_list.cc ...
7 years, 8 months ago (2013-04-03 09:24:35 UTC) #3
raymes
I think brettw's lg is enough here but it looks ok to me.
7 years, 8 months ago (2013-04-03 14:26:00 UTC) #4
brettw
lgtm
7 years, 8 months ago (2013-04-04 04:50:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/13458002/13001
7 years, 8 months ago (2013-04-04 05:08:01 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-04 05:09:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/13458002/13001
7 years, 8 months ago (2013-04-04 11:05:14 UTC) #8
commit-bot: I haz the power
7 years, 8 months ago (2013-04-04 12:01:36 UTC) #9
Message was sent while issue was closed.
Change committed as 192307

Powered by Google App Engine
This is Rietveld 408576698