Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: chrome/browser/chromeos/drive/change_list_processor.cc

Issue 13456002: drive: Fills no-parent entiries in "/drive/other". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased on 192559 Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/drive/drive_file_system.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/drive/change_list_processor.cc
diff --git a/chrome/browser/chromeos/drive/change_list_processor.cc b/chrome/browser/chromeos/drive/change_list_processor.cc
index 66718390858b4449671009f0f640fb4306b0366d..ac2fd7a1cacf411f6c3d9c5a06f4e4a128b866b0 100644
--- a/chrome/browser/chromeos/drive/change_list_processor.cc
+++ b/chrome/browser/chromeos/drive/change_list_processor.cc
@@ -109,9 +109,6 @@ void ChangeListProcessor::ApplyFeeds(
NOTREACHED();
}
- // TODO(haruki): Add pseudo tree structure for "drive"/root" and "drive/other"
- // when we start using those namespaces. The root folder ID is necessary for
- // full feed update.
ApplyEntryProtoMap(is_delta_feed);
// Shouldn't record histograms when processing delta feeds.
@@ -375,23 +372,12 @@ void ChangeListProcessor::FeedToEntryProtoMap(
if (entry_proto->resource_id().empty())
continue;
- // TODO(haruki): Apply mapping from an empty parent to special dummy
- // directory here or in ConvertResourceEntryToDriveEntryProto. See
- // http://crbug.com/174233 http://crbug.com/171207. Until we implement it,
- // ChangeListProcessor ignores such "no parent" entries.
- // Please note that this will cause a temporal issue when
- // - The user unselect all the parent using drive.google.com UI.
- // ChangeListProcessor just ignores the incoming changes and keeps stale
- // metadata. We need to work on this ASAP to reduce confusion.
- if (entry_proto->parent_resource_id().empty()) {
- continue;
- }
-
// Count the number of files.
if (uma_stats && !entry_proto->file_info().is_directory()) {
uma_stats->IncrementNumFiles(
entry_proto->file_specific_info().is_hosted_document());
}
+ // TODO(haruki): Metric for the num of the entries in "other" directory.
std::pair<DriveEntryProtoMap::iterator, bool> ret = entry_proto_map_.
insert(std::make_pair(entry_proto->resource_id(), DriveEntryProto()));
« no previous file with comments | « no previous file | chrome/browser/chromeos/drive/drive_file_system.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698