drive: Fills no-parent entiries in "/drive/other".

chrome/browser/chromeos/drive/change_list_processor.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/drive/change_list_processor.h"
 
 #include <utility>
 
 #include "base/metrics/histogram.h"
 #include "chrome/browser/chromeos/drive/drive.pb.h"
@@ skipping 91 matching lines @@
   } else if (about_resource.get()) {
     largest_changestamp_ = about_resource->largest_change_id();
 
     DVLOG(1) << "Root folder ID is " << about_resource->root_folder_id();
     DCHECK(!about_resource->root_folder_id().empty());
   } else {
     // A full update without AboutResouce will have no effective changestamp.
     NOTREACHED();
   }
 
-  // TODO(haruki): Add pseudo tree structure for "drive"/root" and "drive/other"
-  // when we start using those namespaces. The root folder ID is necessary for
-  // full feed update.
   ApplyEntryProtoMap(is_delta_feed);
 
   // Shouldn't record histograms when processing delta feeds.
   if (!is_delta_feed)
     uma_stats.UpdateFileCountUmaHistograms();
 }
 
 void ChangeListProcessor::ApplyEntryProtoMap(bool is_delta_feed) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
@@ skipping 243 matching lines @@
       DCHECK_GE(change_list->largest_changestamp(), 0);
     }
 
     std::vector<DriveEntryProto>* entries = change_list->mutable_entries();
     for (size_t i = 0; i < entries->size(); ++i) {
       DriveEntryProto* entry_proto = &(*entries)[i];
       // Some document entries don't map into files (i.e. sites).
       if (entry_proto->resource_id().empty())
         continue;
 
-      // TODO(haruki): Apply mapping from an empty parent to special dummy
-      // directory here or in ConvertResourceEntryToDriveEntryProto. See
-      // http://crbug.com/174233 http://crbug.com/171207. Until we implement it,
-      // ChangeListProcessor ignores such "no parent" entries.
-      // Please note that this will cause a temporal issue when
-      // - The user unselect all the parent using drive.google.com UI.
-      // ChangeListProcessor just ignores the incoming changes and keeps stale
-      // metadata. We need to work on this ASAP to reduce confusion.
-      if (entry_proto->parent_resource_id().empty()) {
-        continue;
-      }
-
       // Count the number of files.
       if (uma_stats && !entry_proto->file_info().is_directory()) {
         uma_stats->IncrementNumFiles(
             entry_proto->file_specific_info().is_hosted_document());
       }
+      // TODO(haruki): Metric for the num of the entries in "other" directory.
 
       std::pair<DriveEntryProtoMap::iterator, bool> ret = entry_proto_map_.
           insert(std::make_pair(entry_proto->resource_id(), DriveEntryProto()));
       if (ret.second)
         ret.first->second.Swap(entry_proto);
       else
         LOG(DFATAL) << "Found duplicate file " << entry_proto->base_name();
     }
   }
 }
@@ skipping 58 matching lines @@
 void ChangeListProcessor::Clear() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   entry_proto_map_.clear();
   changed_dirs_.clear();
   largest_changestamp_ = 0;
   on_complete_callback_.Reset();
 }
 
 }  // namespace drive