Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1345563002: Revert of Wake Lock API implementation (Chromium part) (Closed)

Created:
5 years, 3 months ago by Devlin
Modified:
5 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Wake Lock API implementation (Chromium part) (patchset #12 id:220001 of https://codereview.chromium.org/1107333002/ ) Reason for revert: WakeLockTest has been failing on mac 10.9, e.g. WakeLockTest.RendererInitiatedFrameNavigation (run #1): [ RUN ] WakeLockTest.RendererInitiatedFrameNavigation [9365:1287:0914/122522:7769360692956:WARNING:vt_video_decode_accelerator.cc(167)] Failed to create VTDecompressionSession: codecOpenErr (-8973) [9365:1287:0914/122522:7769360765333:WARNING:vt_video_decode_accelerator.cc(209)] Failed to create hardware VideoToolbox session. Hardware accelerated video decoding will be disabled. ../../content/browser/wake_lock/wake_lock_browsertest.cc:302: Failure Value of: HasWakeLock() Actual: false Expected: true https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/11721/steps/content_browsertests%20on%20Mac-10.9/logs/WakeLockTest.RendererInitiatedFrameNavigation Original issue's description: > Wake Lock API implementation (Chromium part) > > This is Chromium part of Wake Lock API implementation as per specification: > http://www.w3.org/TR/wake-lock/ > > The corresponding Blink part is submitted in issue 1084923002 > > Design document: https://docs.google.com/document/d/1KbIENP0wgxtSXDQFn9PbHZ_tAKZfR1Y8u4Hst8LpeaA/edit?usp=sharing > > R=tsepez@chromium.org > R=nasko@chromium.org > R=mlamouri@chromium.org > R=jochen@chromium.org > > Committed: https://crrev.com/334a5a782b578f773f6cd95ee00918300725a2a8 > Cr-Commit-Position: refs/heads/master@{#348602} TBR=jochen@chromium.org,mlamouri@chromium.org,nasko@chromium.org,tsepez@chromium.org,alogvinov@yandex-team.ru NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/dd12ef766648eb12f9162fae15c39443352c14ed Cr-Commit-Position: refs/heads/master@{#348687}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -813 lines) Patch
M content/browser/frame_host/render_frame_host_delegate.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 2 chunks +0 lines, -15 lines 0 comments Download
D content/browser/wake_lock/wake_lock_browsertest.cc View 1 chunk +0 lines, -374 lines 0 comments Download
D content/browser/wake_lock/wake_lock_service_context.h View 1 chunk +0 lines, -62 lines 0 comments Download
D content/browser/wake_lock/wake_lock_service_context.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D content/browser/wake_lock/wake_lock_service_context_unittest.cc View 1 chunk +0 lines, -85 lines 0 comments Download
D content/browser/wake_lock/wake_lock_service_impl.h View 1 chunk +0 lines, -38 lines 0 comments Download
D content/browser/wake_lock/wake_lock_service_impl.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 3 chunks +0 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D content/common/wake_lock_service.mojom View 1 chunk +0 lines, -11 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M content/content_common_mojo_bindings.gyp View 1 chunk +1 line, -2 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.h View 4 chunks +0 lines, -5 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 3 chunks +0 lines, -8 lines 0 comments Download
D content/renderer/wake_lock/wake_lock_dispatcher.h View 1 chunk +0 lines, -32 lines 0 comments Download
D content/renderer/wake_lock/wake_lock_dispatcher.cc View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Devlin
Created Revert of Wake Lock API implementation (Chromium part)
5 years, 3 months ago (2015-09-14 19:43:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345563002/1
5 years, 3 months ago (2015-09-14 19:44:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 19:46:14 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dd12ef766648eb12f9162fae15c39443352c14ed Cr-Commit-Position: refs/heads/master@{#348687}
5 years, 3 months ago (2015-09-14 19:46:58 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:35:56 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd12ef766648eb12f9162fae15c39443352c14ed
Cr-Commit-Position: refs/heads/master@{#348687}

Powered by Google App Engine
This is Rietveld 408576698