Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2121)

Issue 1345453005: Do not drop data on the floor in SpdySession::DoReadLoop. (Closed)

Created:
5 years, 3 months ago by Bence
Modified:
5 years, 2 months ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not drop data on the floor in SpdySession::DoReadLoop. Patch Set 1 adds regression test, watch it specatularily fail in trybot logs. Patch Set 2 fixes the issue. BUG=531570 Committed: https://crrev.com/125cde33c45c37472639c94e4af73760042bdcb0 Cr-Commit-Position: refs/heads/master@{#348726}

Patch Set 1 : Add regression test. #

Patch Set 2 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -3 lines) Patch
M net/spdy/spdy_session.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Bence
Misha: PTAL. Thanks.
5 years, 3 months ago (2015-09-14 17:25:12 UTC) #2
mef
On 2015/09/14 17:25:12, Bence wrote: > Misha: PTAL. Thanks. The fix looks good, and makes ...
5 years, 3 months ago (2015-09-14 19:08:01 UTC) #3
Bence
On 2015/09/14 19:08:01, mef wrote: > On 2015/09/14 17:25:12, Bence wrote: > > Misha: PTAL. ...
5 years, 3 months ago (2015-09-14 19:27:23 UTC) #4
mef
lgtm On 2015/09/14 19:27:23, Bence wrote: > On 2015/09/14 19:08:01, mef wrote: > > On ...
5 years, 3 months ago (2015-09-14 19:36:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345453005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345453005/20001
5 years, 3 months ago (2015-09-14 20:22:33 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-14 21:39:43 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/125cde33c45c37472639c94e4af73760042bdcb0 Cr-Commit-Position: refs/heads/master@{#348726}
5 years, 3 months ago (2015-09-14 21:40:36 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 12:37:32 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/125cde33c45c37472639c94e4af73760042bdcb0
Cr-Commit-Position: refs/heads/master@{#348726}

Powered by Google App Engine
This is Rietveld 408576698