net/spdy/spdy_session.cc - Issue 1345453005: Do not drop data on the floor in SpdySession::DoReadLoop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_session.cc

Issue 1345453005: Do not drop data on the floor in SpdySession::DoReadLoop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/spdy/spdy_session.cc

diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc

index 02336399f4e2eb577f2bca8b35a9c283d0252af6..51c5714cf51910430afed74e03e40e19707077f7 100644

--- a/net/spdy/spdy_session.cc

+++ b/net/spdy/spdy_session.cc

@@ -1398,9 +1398,9 @@ int SpdySession::DoReadLoop(ReadState expected_read_state, int result) {

if (result == ERR_IO_PENDING)

break;

- if (bytes_read_without_yielding > kYieldAfterBytesRead ||

- time_func_() > yield_after_time) {

- read_state_ = READ_STATE_DO_READ;

+ if (read_state_ == READ_STATE_DO_READ &&

+ (bytes_read_without_yielding > kYieldAfterBytesRead ||

+ time_func_() > yield_after_time)) {

base::ThreadTaskRunnerHandle::Get()->PostTask(

FROM_HERE,

base::Bind(&SpdySession::PumpReadLoop, weak_factory_.GetWeakPtr(),

« no previous file with comments | « no previous file | net/spdy/spdy_session_unittest.cc » ('j') | no next file with comments »