Source/WebCore/html/shadow/MediaControlsChromium.cpp - Issue 13454026: Update all float attributes in HTMLMediaElement and related objects to double

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/html/shadow/MediaControlsChromium.cpp

Issue 13454026: Update all float attributes in HTMLMediaElement and related objects to double (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed GTK change since the file is gone now. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/WebCore/html/TimeRanges.h ('K') | « Source/WebCore/html/shadow/MediaControlsBlackBerry.cpp ('k') | Source/WebCore/html/track/TextTrackCue.h » ('j') | Source/WebCore/platform/Clock.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/html/shadow/MediaControlsChromium.cpp

diff --git a/Source/WebCore/html/shadow/MediaControlsChromium.cpp b/Source/WebCore/html/shadow/MediaControlsChromium.cpp

index 85857e873d22880908f9cc02c90b5cd447e69d79..b8ba9be828f5730d7686f323949ab3290306d955 100644

--- a/Source/WebCore/html/shadow/MediaControlsChromium.cpp

+++ b/Source/WebCore/html/shadow/MediaControlsChromium.cpp

@@ -156,7 +156,7 @@ void MediaControlsChromium::reset()

if (!page)

return;

- float duration = m_mediaController->duration();

+ double duration = m_mediaController->duration();

m_durationDisplay->setInnerText(page->theme()->formatMediaControlsTime(duration), ASSERT_NO_EXCEPTION);

m_durationDisplay->setCurrentValue(duration);

@@ -173,8 +173,8 @@ void MediaControlsChromium::playbackStarted()

void MediaControlsChromium::updateCurrentTimeDisplay()

{

- float now = m_mediaController->currentTime();

- float duration = m_mediaController->duration();

+ double now = m_mediaController->currentTime();

+ double duration = m_mediaController->duration();

Page* page = document()->page();

if (!page)