Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: Source/WebCore/html/TimeRanges.h

Issue 13454026: Update all float attributes in HTMLMediaElement and related objects to double (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed GTK change since the file is gone now. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebCore/html/TimeRanges.h
diff --git a/Source/WebCore/html/TimeRanges.h b/Source/WebCore/html/TimeRanges.h
index 425769036ac8ef27387847f30ac41ffe7304b57f..efdcabfc23e339537d4f30322d3f26977c03bdcc 100644
--- a/Source/WebCore/html/TimeRanges.h
+++ b/Source/WebCore/html/TimeRanges.h
@@ -41,7 +41,7 @@ public:
{
return adoptRef(new TimeRanges);
}
- static PassRefPtr<TimeRanges> create(float start, float end)
+ static PassRefPtr<TimeRanges> create(double start, double end)
{
return adoptRef(new TimeRanges(start, end));
}
@@ -52,32 +52,32 @@ public:
void unionWith(const TimeRanges*);
unsigned length() const { return m_ranges.size(); }
- float start(unsigned index, ExceptionCode&) const;
- float end(unsigned index, ExceptionCode&) const;
+ double start(unsigned index, ExceptionCode&) const;
+ double end(unsigned index, ExceptionCode&) const;
- void add(float start, float end);
+ void add(double start, double end);
- bool contain(float time) const;
+ bool contain(double time) const;
- float nearest(float time) const;
+ double nearest(double time) const;
private:
TimeRanges() { }
- TimeRanges(float start, float end);
+ TimeRanges(double start, double end);
eseidel 2013/04/05 21:44:14 Do we have a lot of these? Is doubling the size a
acolwell GONE FROM CHROMIUM 2013/04/05 22:29:11 No. There is usually only one per HTMLMediaElement
TimeRanges(const TimeRanges&);
// We consider all the Ranges to be semi-bounded as follow: [start, end[
struct Range {
Range() { }
- Range(float start, float end)
+ Range(double start, double end)
{
m_start = start;
m_end = end;
}
- float m_start;
- float m_end;
+ double m_start;
+ double m_end;
- inline bool isPointInRange(float point) const
+ inline bool isPointInRange(double point) const
{
return m_start <= point && point < m_end;
}

Powered by Google App Engine
This is Rietveld 408576698