Source/WebCore/html/shadow/MediaControlsApple.cpp - Issue 13454026: Update all float attributes in HTMLMediaElement and related objects to double

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/html/shadow/MediaControlsApple.cpp

Issue 13454026: Update all float attributes in HTMLMediaElement and related objects to double (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed GTK change since the file is gone now. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/WebCore/html/TimeRanges.h ('K') | « Source/WebCore/html/shadow/MediaControls.cpp ('k') | Source/WebCore/html/shadow/MediaControlsBlackBerry.h » ('j') | Source/WebCore/platform/Clock.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/html/shadow/MediaControlsApple.cpp

diff --git a/Source/WebCore/html/shadow/MediaControlsApple.cpp b/Source/WebCore/html/shadow/MediaControlsApple.cpp

index 91a8a77cd11977186eaaa161c2006c19529d6015..c93ba6890a2c1be3d3408336944b3360c2c0340c 100644

--- a/Source/WebCore/html/shadow/MediaControlsApple.cpp

+++ b/Source/WebCore/html/shadow/MediaControlsApple.cpp

@@ -322,7 +322,7 @@ void MediaControlsApple::reset()

else

m_fullScreenButton->hide();

- float duration = m_mediaController->duration();

+ double duration = m_mediaController->duration();

if (std::isfinite(duration) || page->theme()->hasOwnDisabledStateHandlingFor(MediaSliderPart)) {

m_timeline->setDuration(duration);

m_timelineContainer->show();

@@ -382,8 +382,8 @@ void MediaControlsApple::reset()

void MediaControlsApple::updateCurrentTimeDisplay()

{

- float now = m_mediaController->currentTime();

- float duration = m_mediaController->duration();

+ double now = m_mediaController->currentTime();

+ double duration = m_mediaController->duration();

Page* page = document()->page();

if (!page)