Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: Source/WebCore/html/HTMLMediaElement.idl

Issue 13454026: Update all float attributes in HTMLMediaElement and related objects to double (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed GTK change since the file is gone now. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebCore/html/HTMLMediaElement.idl
diff --git a/Source/WebCore/html/HTMLMediaElement.idl b/Source/WebCore/html/HTMLMediaElement.idl
index 8d658c0d00848536484b1ef7f858a2be81e3a78c..cb3750d451a60ae7bc72c0996dd94c03494bee7b 100644
--- a/Source/WebCore/html/HTMLMediaElement.idl
+++ b/Source/WebCore/html/HTMLMediaElement.idl
@@ -62,14 +62,14 @@ readonly attribute unsigned short readyState;
readonly attribute boolean seeking;
// playback state
-attribute float currentTime
+attribute double currentTime
setter raises (DOMException);
readonly attribute double initialTime;
-readonly attribute float startTime;
-readonly attribute float duration;
+readonly attribute double startTime;
eseidel 2013/04/05 21:44:14 This is a web-observable change, no? I guess all
acolwell GONE FROM CHROMIUM 2013/04/05 22:29:11 Yes it is observable. If you set any of these prop
+readonly attribute double duration;
readonly attribute boolean paused;
-attribute float defaultPlaybackRate;
-attribute float playbackRate;
+attribute double defaultPlaybackRate;
+attribute double playbackRate;
readonly attribute TimeRanges played;
readonly attribute TimeRanges seekable;
readonly attribute boolean ended;
@@ -80,7 +80,7 @@ void pause();
// controls
attribute boolean controls;
-attribute float volume
+attribute double volume
setter raises (DOMException);
attribute boolean muted;
attribute [Reflect=muted] boolean defaultMuted;

Powered by Google App Engine
This is Rietveld 408576698