Issue 1345303002: Allow PRESUBMIT run pcg on trybuilder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1345303002: Allow PRESUBMIT run pcg on trybuilder. (Closed)

Created:
5 years, 3 months ago by tandrii(chromium)

Modified:
5 years, 3 months ago

Reviewers:
Vadim Sh., tandrii_google

CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org

Base URL:
https://github.com/luci/gae@master

Target Ref:
refs/heads/master

Project:
luci-gae

Visibility:
Public.

More Reviews

Description

Allow PRESUBMIT run pcg on trybuilder. R=vadimsh@chromium.org BUG=529936 Committed: https://github.com/luci/gae/commit/fc2b1f87c0a7a70e93d6175bf4735428dde3ede3

Patch Set 1 #

Patch Set 2 : added CQ config change #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	PRESUBMIT.py	View		1 chunk	+4 lines, -1 line	0 comments	Download
	M	infra/config/cq.cfg	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

tandrii_google

PTAL improves the taste of https://codereview.chromium.org/1350923002

5 years, 3 months ago (2015-09-16 20:54:09 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345303002/20001

5 years, 3 months ago (2015-09-16 21:17:21 UTC) #6

commit-bot: I haz the power

5 years, 3 months ago (2015-09-16 21:18:42 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/fc2b1f87c0a7a70e93d6175bf4735428dde3ede3

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages