Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1350923002: Add presubmit trybuilder to Luci-GAE repository. (Closed)

Created:
5 years, 3 months ago by tandrii(chromium)
Modified:
5 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add presubmit trybuilder to Luci-GAE repository. This changes the infra/luci_gae recipe to run presubmit with pcg properly, and adds a new builder to master. TEST=locally with https://codereview.chromium.org/1345303002/ R=vadimsh@chromium.org BUG=529936 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296720

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -22 lines) Patch
M masters/master.tryserver.infra/builders.pyl View 1 chunk +7 lines, -0 lines 0 comments Download
M scripts/slave/recipes/infra/luci_gae.py View 5 chunks +62 lines, -10 lines 0 comments Download
A + scripts/slave/recipes/infra/luci_gae.expected/presubmit_try_job.json View 6 chunks +14 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tandrii_google
PTAL served best with secret souce https://codereview.chromium.org/1345303002/
5 years, 3 months ago (2015-09-16 20:54:10 UTC) #2
Vadim Sh.
lgtm copy-pasta :-/
5 years, 3 months ago (2015-09-16 21:03:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350923002/1
5 years, 3 months ago (2015-09-16 21:17:12 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-16 22:03:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296720

Powered by Google App Engine
This is Rietveld 408576698