[MD settings] adding dom-if to hide homepage settings

[MD settings] adding dom-if to hide homepage settings

This is the separated CL from CL 1345913002 to add the dom-if to hide/show the radio buttons.

BUG=531786

[dschuyler, 2015-09-16 20:11:40]

dschuyler@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2015-09-16 21:50:14]

https://codereview.chromium.org/1345253002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/appearance_page/appearance_page.html
(right):

https://codereview.chromium.org/1345253002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/appearance_page/appearance_page.html:28:
<template is="dom-if" if="{{prefs.browser.show_home_button.value}}">
indent inside the template

https://codereview.chromium.org/1345253002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/appearance_page/appearance_page.html:32:
<paper-radio-button name="t"><span>[[i18n_.homePageNtp]]</span>
why do you need the <span>?

<paper-radio-button name="t">[[i18n_.homePageNtp]]</paper-radio-button>

note: wrapping lines with <x-tag>[[...]]</x-tag> doesn't always work.  in this
case: just go over 80 cols, imo

[dschuyler, 2015-09-16 22:06:44]

https://codereview.chromium.org/1345253002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/appearance_page/appearance_page.html
(right):

https://codereview.chromium.org/1345253002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/appearance_page/appearance_page.html:28:
<template is="dom-if" if="{{prefs.browser.show_home_button.value}}">
On 2015/09/16 21:50:13, Dan Beam wrote:
> indent inside the template

Done.

https://codereview.chromium.org/1345253002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/appearance_page/appearance_page.html:32:
<paper-radio-button name="t"><span>[[i18n_.homePageNtp]]</span>
On 2015/09/16 21:50:14, Dan Beam wrote:
> why do you need the <span>?
> 
> <paper-radio-button name="t">[[i18n_.homePageNtp]]</paper-radio-button>
> 
> note: wrapping lines with <x-tag>[[...]]</x-tag> doesn't always work.  in this
> case: just go over 80 cols, imo

Thanks, I didn't know it was ok to go over the 80 cols.  And yeah,
using <span> makes it work while wrapping the rest of the line.

Done.

[Dan Beam, 2015-09-16 22:08:35]

lgtm

https://codereview.chromium.org/1345253002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/appearance_page/appearance_page.html
(right):

https://codereview.chromium.org/1345253002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/appearance_page/appearance_page.html:32:
<paper-radio-button name="t">[[i18n_.homePageNtp]]</paper-radio-button>
<paper-radio-button
    name="t">[[i18n_.homePageNtp]]</paper-radio-button>

seems like it'd also work

[dschuyler, 2015-09-18 22:22:37]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2015-09-18 22:22:38]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1345253002/#ps60001
(title: "review changes")

[commit-bot: I haz the power, 2015-09-18 22:23:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1345253002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1345253002/60001

[commit-bot: I haz the power, 2015-09-18 22:26:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-18 22:26:06]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)