Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1345063003: Adapt parseFontVariantLigatures to use CSSParserTokenRange (Closed)

Created:
5 years, 3 months ago by rwlbuis
Modified:
5 years, 3 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Adapt parseFontVariantLigatures to use CSSParserTokenRange Adapt parseFontVariantLigatures to use CSSParserTokenRange, rename it to consumeFontVariantLigatures and call it in parseSingleValue. BUG=499780 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202415

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -61 lines) Patch
M Source/core/css/parser/CSSPropertyParser.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 2 chunks +47 lines, -0 lines 0 comments Download
M Source/core/css/parser/LegacyCSSPropertyParser.cpp View 3 chunks +1 line, -59 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rwlbuis
PTAL.
5 years, 3 months ago (2015-09-17 00:38:36 UTC) #2
Timothy Loh
On 2015/09/17 00:38:36, rwlbuis wrote: > PTAL. lgtm
5 years, 3 months ago (2015-09-17 00:40:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345063003/1
5 years, 3 months ago (2015-09-17 00:52:11 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 02:20:55 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202415

Powered by Google App Engine
This is Rietveld 408576698