Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1345043003: Revert of [KeyEvent Mac] Move WebInputEventFactory into chromium. (Closed)

Created:
5 years, 3 months ago by kochi
Modified:
5 years, 3 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, tdresser+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su, jdduke+watch_chromium.org, Habib Virji
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [KeyEvent Mac] Move WebInputEventFactory into chromium. (patchset #7 id:120001 of https://codereview.chromium.org/1331013004/ ) Reason for revert: This caused compile failure on MacOSX 10.9 Retina bot. The relevant error log: ../../content/browser/renderer_host/input/web_input_event_builders_mac.mm:889:10: error: use of undeclared identifier 'NSEventTypeSmartMagnify'; did you mean 'NSEventTypeMagnify'? case NSEventTypeSmartMagnify: ^~~~~~~~~~~~~~~~~~~~~~~ NSEventTypeMagnify /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSEvent.h:48:5: note: 'NSEventTypeMagnify' declared here NSEventTypeMagnify = 30, ^ ../../content/browser/renderer_host/input/web_input_event_builders_mac.mm:889:10: error: duplicate case value 'NSEventTypeMagnify' case NSEventTypeSmartMagnify: ^ ../../content/browser/renderer_host/input/web_input_event_builders_mac.mm:885:10: note: previous case defined here case NSEventTypeMagnify: ^ 2 errors generated. ninja: build stopped: subcommand failed. Original issue's description: > [KeyEvent Mac] Move WebInputEventFactory into chromium. > > There was an inconsistency on the Mac platform that the WebInputEventFactory > (old WebKit code) was being used. Other platforms have migrated to using > builders and it was weird for the Mac code path to have some code on one > side of the blink divide that others didn't. This change brings the Mac > platform inline with the others by moving the input event > factory from blink into chromium. > > blink change: https://codereview.chromium.org/1335673002/ > > BUG=493833, 237267 > > Committed: https://crrev.com/8db5ca887d4560ed15bf5e6e2dce69dc85868f25 > Cr-Commit-Position: refs/heads/master@{#348989} TBR=wez@chromium.org,sadrul@chromium.org,asvitkine@chromium.org,mnaganov@chromium.org,piman@chromium.org,dtapuska@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=493833, 237267 Committed: https://crrev.com/bd8d56bb5c281d4b3ca5306dff59294108329c08 Cr-Commit-Position: refs/heads/master@{#349058}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1162 lines) Patch
M content/browser/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
D content/browser/renderer_host/input/web_input_event_builders_mac.h View 1 chunk +0 lines, -41 lines 0 comments Download
D content/browser/renderer_host/input/web_input_event_builders_mac.mm View 1 chunk +0 lines, -912 lines 0 comments Download
D content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm View 1 chunk +0 lines, -163 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_util.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_util.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M content/browser/renderer_host/native_web_keyboard_event_mac.mm View 2 chunks +6 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 13 chunks +16 lines, -14 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aura.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M tools/copyright_scanner/third_party_files_whitelist.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/events/cocoa/events_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/events/keycodes/keyboard_code_conversion_mac.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
kochi
Created Revert of [KeyEvent Mac] Move WebInputEventFactory into chromium.
5 years, 3 months ago (2015-09-16 01:18:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345043003/1
5 years, 3 months ago (2015-09-16 01:18:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-16 01:19:28 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bd8d56bb5c281d4b3ca5306dff59294108329c08 Cr-Commit-Position: refs/heads/master@{#349058}
5 years, 3 months ago (2015-09-16 01:20:01 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:52:09 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd8d56bb5c281d4b3ca5306dff59294108329c08
Cr-Commit-Position: refs/heads/master@{#349058}

Powered by Google App Engine
This is Rietveld 408576698