Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1335673002: [KeyEvent Mac] Remove the WebInputEventFactory from blink. (Closed)

Created:
5 years, 3 months ago by dtapuska
Modified:
5 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[KeyEvent Mac] Remove the WebInputEventFactory from blink. The code has migrated into the chromium code base. See change https://codereview.chromium.org/1331013004/ for the chromium side change. Only Mac used the WebInputEventFactory; the rest of the platforms had their code converted into chromium long ago. BUG=493833, 237267 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202454

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1464 lines) Patch
D Source/web/WebInputEventFactoryMac.mm View 1 chunk +0 lines, -1204 lines 0 comments Download
D Source/web/tests/WebInputEventFactoryTestMac.mm View 1 chunk +0 lines, -194 lines 0 comments Download
M Source/web/web.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/web.gypi View 1 2 chunks +0 lines, -2 lines 0 comments Download
M public/blink_headers.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
D public/web/mac/WebInputEventFactory.h View 1 chunk +0 lines, -62 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
dtapuska
5 years, 3 months ago (2015-09-10 15:00:01 UTC) #2
tkent
lgtm
5 years, 3 months ago (2015-09-10 23:56:52 UTC) #3
Wez
nit: Make clear in CL description that this was really only the Mac impl remaining, ...
5 years, 3 months ago (2015-09-11 20:36:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335673002/1
5 years, 3 months ago (2015-09-16 00:42:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/97888) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 3 months ago (2015-09-16 00:44:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335673002/20001
5 years, 3 months ago (2015-09-17 14:35:32 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/100994)
5 years, 3 months ago (2015-09-17 14:37:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1335673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1335673002/20001
5 years, 3 months ago (2015-09-17 16:39:46 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 16:49:00 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202454

Powered by Google App Engine
This is Rietveld 408576698