Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1344753002: Update tests for chrome, as MediaStream label, ended attributes and stop() method will be removed (Closed)

Created:
5 years, 3 months ago by shiva.jm
Modified:
5 years, 3 months ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update tests for chrome, as MediaStream label, ended attributes and stop() method will be removed Also CL: https://codereview.chromium.org/1312213006/ depends on these CL to commit first. Intent to Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/LcZGlM9OBqs Intent to Remove, which became an Intent to Deprecate: https://groups.google.com/a/chromium.org/d/msg/blink-dev/s0UsMk8i2YM/WpepA4w3mPEJ BUG=338500 Committed: https://crrev.com/310ea93837e4a95944fcd82ff54d0e0ea5186a2c Cr-Commit-Position: refs/heads/master@{#349094}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M chrome/test/data/extensions/api_test/tab_capture/active_tab_chrome_pages.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/tab_capture/active_tab_permission_test.js View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/tab_capture/api_tests.js View 1 6 chunks +9 lines, -6 lines 0 comments Download
M chrome/test/data/extensions/api_test/tab_capture/constraints.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/tab_capture/fullscreen_test.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/webrtc/webrtc-simulcast.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 29 (13 generated)
shiva.jm
pls have a look.
5 years, 3 months ago (2015-09-16 06:23:36 UTC) #2
tommi (sloooow) - chröme
lgtm
5 years, 3 months ago (2015-09-16 08:30:29 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344753002/20001
5 years, 3 months ago (2015-09-16 08:31:51 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/121631) cast_shell_android on ...
5 years, 3 months ago (2015-09-16 08:37:56 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344753002/20001
5 years, 3 months ago (2015-09-16 08:44:36 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/133030) linux_chromium_gn_dbg on ...
5 years, 3 months ago (2015-09-16 08:50:19 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344753002/20001
5 years, 3 months ago (2015-09-16 09:01:55 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/63482)
5 years, 3 months ago (2015-09-16 09:05:56 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344753002/20001
5 years, 3 months ago (2015-09-16 09:17:43 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/98439) win_chromium_compile_dbg_ng on ...
5 years, 3 months ago (2015-09-16 09:26:03 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344753002/20001
5 years, 3 months ago (2015-09-16 10:10:32 UTC) #22
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-16 10:28:02 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344753002/20001
5 years, 3 months ago (2015-09-16 10:32:43 UTC) #26
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-16 10:38:29 UTC) #27
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/310ea93837e4a95944fcd82ff54d0e0ea5186a2c Cr-Commit-Position: refs/heads/master@{#349094}
5 years, 3 months ago (2015-09-16 10:39:11 UTC) #28
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:54:24 UTC) #29
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/310ea93837e4a95944fcd82ff54d0e0ea5186a2c
Cr-Commit-Position: refs/heads/master@{#349094}

Powered by Google App Engine
This is Rietveld 408576698