chrome/test/data/extensions/api_test/tab_capture/active_tab_permission_test.js - Issue 1344753002: Update tests for chrome, as MediaStream label, ended attributes and stop() method will be removed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/tab_capture/active_tab_permission_test.js

Issue 1344753002: Update tests for chrome, as MediaStream label, ended attributes and stop() method will be removed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/tab_capture/active_tab_chrome_pages.js ('k') | chrome/test/data/extensions/api_test/tab_capture/api_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/tab_capture/active_tab_permission_test.js

diff --git a/chrome/test/data/extensions/api_test/tab_capture/active_tab_permission_test.js b/chrome/test/data/extensions/api_test/tab_capture/active_tab_permission_test.js

index 61d3a2f43975aabc1dc4e27361957dc1319bdc46..4a4ab4a3ccef8035f2c5e2d7c5094bf32e6c2b5f 100644

--- a/chrome/test/data/extensions/api_test/tab_capture/active_tab_permission_test.js

+++ b/chrome/test/data/extensions/api_test/tab_capture/active_tab_permission_test.js

@@ -5,7 +5,8 @@

var afterWhitelistExtension = function(msg) {

chrome.tabCapture.capture({audio: true, video: true}, function(stream) {

chrome.test.assertTrue(!!stream);

- stream.stop();

+ stream.getVideoTracks()[0].stop();

+ stream.getAudioTracks()[0].stop();

chrome.test.succeed();

});

};

@@ -20,7 +21,8 @@ var afterOpenNewTab = function(msg) {

var afterGrantPermission = function(msg) {

chrome.tabCapture.capture({audio: true, video: true}, function(stream) {

chrome.test.assertTrue(!!stream);

- stream.stop();

+ stream.getVideoTracks()[0].stop();

+ stream.getAudioTracks()[0].stop();

chrome.test.sendMessage('ready3', afterOpenNewTab);

});

};