Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1344583003: Recipe package system. (Closed)

Created:
5 years, 3 months ago by luqui
Modified:
5 years, 3 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Base URL:
git@github.com:luci/recipes-py.git@master
Target Ref:
refs/heads/master
Project:
recipes-py
Visibility:
Public.

Description

Recipe package system. This provides the infrastructure to create "recipe packages", which are collections of recipes and modules which can depend on each other. It provides a tool recipes.py which interacts with a package. Corresponding tools/build CL which has a lot of this code reviewed already: https://codereview.chromium.org/1241323004 BUG=459840 Committed: https://github.com/luci/recipes-py/commit/66db6b671a99b1c7370b4272ab2bf0b5126f0ac8

Patch Set 1 #

Patch Set 2 : Killed engine_revision (package.py and package.proto changed (am I really writing this)) #

Patch Set 3 : Recompiled proto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31152 lines, -121 lines) Patch
A .gitignore View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A PRESUBMIT.py View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A infra/config/recipes.cfg View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M recipe_engine/config.py View 1 2 3 chunks +3 lines, -9 lines 0 comments Download
M recipe_engine/config_types.py View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
A recipe_engine/doc.py View 1 2 1 chunk +116 lines, -0 lines 0 comments Download
M recipe_engine/lint_test.py View 1 2 3 chunks +7 lines, -1 line 0 comments Download
M recipe_engine/loader.py View 1 2 7 chunks +54 lines, -41 lines 0 comments Download
A recipe_engine/package.proto View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
A recipe_engine/package.py View 1 2 1 chunk +585 lines, -0 lines 0 comments Download
A recipe_engine/package_pb2.py View 1 2 1 chunk +142 lines, -0 lines 0 comments Download
M recipe_engine/recipe_api.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M recipe_engine/run.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_engine/simulation_test.py View 1 2 4 chunks +11 lines, -7 lines 0 comments Download
M recipe_engine/third_party/expect_tests/main.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download
A recipe_engine/third_party/google/__init__.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + recipe_engine/third_party/google/protobuf/__init__.py View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + recipe_engine/third_party/google/protobuf/compiler/__init__.py View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A recipe_engine/third_party/google/protobuf/compiler/plugin_pb2.py View 1 2 1 chunk +166 lines, -0 lines 0 comments Download
A recipe_engine/third_party/google/protobuf/descriptor.py View 1 2 1 chunk +713 lines, -0 lines 0 comments Download
A recipe_engine/third_party/google/protobuf/descriptor_database.py View 1 2 1 chunk +120 lines, -0 lines 0 comments Download
A recipe_engine/third_party/google/protobuf/descriptor_pb2.py View 1 2 1 chunk +1346 lines, -0 lines 0 comments Download
A recipe_engine/third_party/google/protobuf/descriptor_pool.py View 1 2 1 chunk +527 lines, -0 lines 0 comments Download
A + recipe_engine/third_party/google/protobuf/internal/__init__.py View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A recipe_engine/third_party/google/protobuf/internal/api_implementation.py View 1 2 1 chunk +87 lines, -0 lines 0 comments Download
A recipe_engine/third_party/google/protobuf/internal/containers.py View 1 2 1 chunk +269 lines, -0 lines 0 comments Download
A recipe_engine/third_party/google/protobuf/internal/cpp_message.py View 1 2 1 chunk +663 lines, -0 lines 0 comments Download
A recipe_engine/third_party/google/protobuf/internal/decoder.py View 1 2 1 chunk +720 lines, -0 lines 0 comments Download
A recipe_engine/third_party/google/protobuf/internal/encoder.py View 1 2 1 chunk +769 lines, -0 lines 0 comments Download
A recipe_engine/third_party/google/protobuf/internal/enum_type_wrapper.py View 1 2 1 chunk +89 lines, -0 lines 0 comments Download
A recipe_engine/third_party/google/protobuf/internal/message_listener.py View 1 2 1 chunk +78 lines, -0 lines 0 comments Download
A recipe_engine/third_party/google/protobuf/internal/python_message.py View 1 2 1 chunk +1150 lines, -0 lines 0 comments Download
A recipe_engine/third_party/google/protobuf/internal/type_checkers.py View 1 2 1 chunk +286 lines, -0 lines 0 comments Download
A recipe_engine/third_party/google/protobuf/internal/wire_format.py View 1 2 1 chunk +268 lines, -0 lines 0 comments Download
A recipe_engine/third_party/google/protobuf/message.py View 1 2 1 chunk +280 lines, -0 lines 0 comments Download
A recipe_engine/third_party/google/protobuf/message_factory.py View 1 2 1 chunk +113 lines, -0 lines 0 comments Download
A recipe_engine/third_party/google/protobuf/reflection.py View 1 2 1 chunk +169 lines, -0 lines 0 comments Download
A recipe_engine/third_party/google/protobuf/service.py View 1 2 1 chunk +226 lines, -0 lines 0 comments Download
A recipe_engine/third_party/google/protobuf/service_reflection.py View 1 2 1 chunk +284 lines, -0 lines 0 comments Download
A recipe_engine/third_party/google/protobuf/text_format.py View 1 2 1 chunk +739 lines, -0 lines 0 comments Download
A recipe_engine/third_party/mock-1.0.1/LICENSE View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A recipe_engine/third_party/mock-1.0.1/README.google View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A recipe_engine/third_party/mock-1.0.1/README.txt View 1 2 1 chunk +177 lines, -0 lines 0 comments Download
A recipe_engine/third_party/mock-1.0.1/mock.py View 1 2 1 chunk +2367 lines, -0 lines 0 comments Download
A recipe_engine/third_party/pkg_resources.py View 1 2 1 chunk +2966 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/__init__.py View 1 2 1 chunk +150 lines, -0 lines 0 comments Download
A + recipe_engine/third_party/setuptools/_vendor/__init__.py View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A recipe_engine/third_party/setuptools/_vendor/packaging/__about__.py View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/_vendor/packaging/__init__.py View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/_vendor/packaging/_compat.py View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/_vendor/packaging/_structures.py View 1 2 1 chunk +78 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/_vendor/packaging/specifiers.py View 1 2 1 chunk +734 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/_vendor/packaging/version.py View 1 2 1 chunk +376 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/archive_util.py View 1 2 1 chunk +166 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/cli.exe View 1 2 Binary file 0 comments Download
A recipe_engine/third_party/setuptools/cli-32.exe View 1 2 Binary file 0 comments Download
A recipe_engine/third_party/setuptools/cli-64.exe View 1 2 Binary file 0 comments Download
A recipe_engine/third_party/setuptools/cli-arm-32.exe View 1 2 Binary file 0 comments Download
A recipe_engine/third_party/setuptools/command/__init__.py View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/command/alias.py View 1 2 1 chunk +78 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/command/bdist_egg.py View 1 2 1 chunk +479 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/command/bdist_rpm.py View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/command/bdist_wininst.py View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/command/build_ext.py View 1 2 1 chunk +305 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/command/build_py.py View 1 2 1 chunk +230 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/command/develop.py View 1 2 1 chunk +169 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/command/easy_install.py View 1 2 1 chunk +2157 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/command/egg_info.py View 1 2 1 chunk +473 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/command/install.py View 1 2 1 chunk +125 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/command/install_egg_info.py View 1 2 1 chunk +116 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/command/install_lib.py View 1 2 1 chunk +118 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/command/install_scripts.py View 1 2 1 chunk +55 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/command/launcher manifest.xml View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/command/register.py View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/command/rotate.py View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/command/saveopts.py View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/command/sdist.py View 1 2 1 chunk +252 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/command/setopt.py View 1 2 1 chunk +150 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/command/test.py View 1 2 1 chunk +175 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/command/upload_docs.py View 1 2 1 chunk +191 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/compat.py View 1 2 1 chunk +66 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/depends.py View 1 2 1 chunk +215 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/dist.py View 1 2 1 chunk +867 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/extension.py View 1 2 1 chunk +57 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/gui.exe View 1 2 Binary file 0 comments Download
A recipe_engine/third_party/setuptools/gui-32.exe View 1 2 Binary file 0 comments Download
A recipe_engine/third_party/setuptools/gui-64.exe View 1 2 Binary file 0 comments Download
A recipe_engine/third_party/setuptools/gui-arm-32.exe View 1 2 Binary file 0 comments Download
A recipe_engine/third_party/setuptools/lib2to3_ex.py View 1 2 1 chunk +58 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/msvc9_support.py View 1 2 1 chunk +64 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/package_index.py View 1 2 1 chunk +1055 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/py26compat.py View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/py27compat.py View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/py31compat.py View 1 2 1 chunk +52 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/sandbox.py View 1 2 1 chunk +336 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/script.tmpl View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/script (dev).tmpl View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/site-patch.py View 1 2 1 chunk +76 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/ssl_support.py View 1 2 1 chunk +241 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/svn_utils.py View 1 2 1 chunk +585 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/tests/__init__.py View 1 2 1 chunk +351 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/tests/environment.py View 1 2 1 chunk +118 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/tests/py26compat.py View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/tests/script-with-bom.py View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/tests/server.py View 1 2 1 chunk +82 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/tests/test_bdist_egg.py View 1 2 1 chunk +72 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/tests/test_build_ext.py View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/tests/test_develop.py View 1 2 1 chunk +122 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/tests/test_dist_info.py View 1 2 1 chunk +83 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/tests/test_easy_install.py View 1 2 1 chunk +462 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/tests/test_egg_info.py View 1 2 1 chunk +268 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/tests/test_find_packages.py View 1 2 1 chunk +170 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/tests/test_integration.py View 1 2 1 chunk +83 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/tests/test_markerlib.py View 1 2 1 chunk +68 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/tests/test_msvc9compiler.py View 1 2 1 chunk +157 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/tests/test_packageindex.py View 1 2 1 chunk +203 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/tests/test_resources.py View 1 2 1 chunk +655 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/tests/test_sandbox.py View 1 2 1 chunk +83 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/tests/test_sdist.py View 1 2 1 chunk +552 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/tests/test_svn.py View 1 2 1 chunk +245 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/tests/test_test.py View 1 2 1 chunk +126 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/tests/test_upload_docs.py View 1 2 1 chunk +72 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/unicode_utils.py View 1 2 1 chunk +41 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/utils.py View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/version.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A recipe_engine/third_party/setuptools/windows_support.py View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
A recipe_engine/types.py View 1 2 1 chunk +70 lines, -0 lines 0 comments Download
A recipe_engine/unittests/doc_test.py View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A recipe_engine/unittests/multi_repo_test.py View 1 2 1 chunk +277 lines, -0 lines 0 comments Download
A recipe_engine/unittests/package_test.py View 1 2 1 chunk +162 lines, -0 lines 0 comments Download
A recipe_engine/unittests/run_test.py View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
M recipe_modules/example/__init__.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/generator_script/__init__.py View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M recipe_modules/json/__init__.py View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M recipe_modules/path/__init__.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/properties/api.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M recipe_modules/properties/example.py View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M recipe_modules/python/__init__.py View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M recipe_modules/step/__init__.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/step/example.py View 1 2 4 chunks +18 lines, -8 lines 0 comments Download
M recipe_modules/step/example.expected/basic.json View 1 2 2 chunks +11 lines, -9 lines 0 comments Download
M recipe_modules/step/example.expected/defer_results.json View 1 2 2 chunks +9 lines, -1 line 0 comments Download
M recipe_modules/step/example.expected/infra_failure.json View 1 2 2 chunks +11 lines, -9 lines 0 comments Download
M recipe_modules/step/example.expected/invalid_access.json View 1 2 3 chunks +11 lines, -4 lines 0 comments Download
A + recipe_modules/step/example.expected/warning.json View 1 2 1 chunk +4 lines, -12 lines 0 comments Download
A recipes.py View 1 2 1 chunk +253 lines, -0 lines 0 comments Download
A unittests/stdlib_test.py View 1 2 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
luqui
5 years, 3 months ago (2015-09-14 17:53:34 UTC) #2
luqui
5 years, 3 months ago (2015-09-15 18:26:06 UTC) #3
Message was sent while issue was closed. 
Committed patchset #3 (id:20001) manually as
66db6b671a99b1c7370b4272ab2bf0b5126f0ac8.

Powered by Google App Engine
This is Rietveld 408576698