Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1344543002: [tracing] Expose level of detail of memory dumps in the trace JSON (Closed)

Created:
5 years, 3 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 3 months ago
Reviewers:
petrcermak
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cleanup_levdetail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tracing] Expose level of detail of memory dumps in the trace JSON This small CL exposes a "level_of_detail" field in the trace JSON, as a sibling of "allocators". e.g., "dumps":{ "allocators":{...}, "allocators_graph":[...], "level_of_detail":"light", "process_totals":{...} } BUG=524345 Committed: https://crrev.com/df2ce273eeb2a30602349d3e7f0de5a445abccbc Cr-Commit-Position: refs/heads/master@{#348861}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M base/trace_event/memory_dump_manager.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
Primiano Tucci (use gerrit)
PTAL, small patch. Of course after reviewing this you'll need to do the UI (just ...
5 years, 3 months ago (2015-09-14 13:10:52 UTC) #2
petrcermak
LGTM. Thanks, Petr
5 years, 3 months ago (2015-09-14 13:18:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344543002/1
5 years, 3 months ago (2015-09-15 09:03:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 10:03:43 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/df2ce273eeb2a30602349d3e7f0de5a445abccbc Cr-Commit-Position: refs/heads/master@{#348861}
5 years, 3 months ago (2015-09-15 10:04:37 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:43:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df2ce273eeb2a30602349d3e7f0de5a445abccbc
Cr-Commit-Position: refs/heads/master@{#348861}

Powered by Google App Engine
This is Rietveld 408576698