|
|
Created:
5 years, 3 months ago by Camillo Bruni Modified:
5 years, 3 months ago Reviewers:
mvstanton CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionPreserve the ElementsKind in builtin.cc Slice early return
LOG=N
BUG=chromium:531348
Committed: https://crrev.com/5ee2ea3caeb8d11c106ec50728e25a624cc82765
Cr-Commit-Position: refs/heads/master@{#30711}
Patch Set 1 #
Created: 5 years, 3 months ago
Messages
Total messages: 15 (6 generated)
cbruni@chromium.org changed reviewers: + mvstanton@chromium.org
The CQ bit was checked by cbruni@chromium.org
PTAL
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344493004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344493004/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
NIce fix! LGTM.
The CQ bit was checked by cbruni@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344493004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344493004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/5742)
The CQ bit was checked by cbruni@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344493004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344493004/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5ee2ea3caeb8d11c106ec50728e25a624cc82765 Cr-Commit-Position: refs/heads/master@{#30711} |