Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1344493004: Preserve the ElementsKind in builtin.cc Slice early return (Closed)

Created:
5 years, 3 months ago by Camillo Bruni
Modified:
5 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Preserve the ElementsKind in builtin.cc Slice early return LOG=N BUG=chromium:531348 Committed: https://crrev.com/5ee2ea3caeb8d11c106ec50728e25a624cc82765 Cr-Commit-Position: refs/heads/master@{#30711}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/builtins.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
Camillo Bruni
PTAL
5 years, 3 months ago (2015-09-14 08:51:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344493004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344493004/1
5 years, 3 months ago (2015-09-14 08:51:38 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-14 08:51:39 UTC) #6
mvstanton
NIce fix! LGTM.
5 years, 3 months ago (2015-09-14 09:30:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344493004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344493004/1
5 years, 3 months ago (2015-09-14 09:35:54 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/5742)
5 years, 3 months ago (2015-09-14 09:38:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344493004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344493004/1
5 years, 3 months ago (2015-09-14 10:30:58 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 10:32:42 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-14 10:33:02 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5ee2ea3caeb8d11c106ec50728e25a624cc82765
Cr-Commit-Position: refs/heads/master@{#30711}

Powered by Google App Engine
This is Rietveld 408576698