src/builtins.cc - Issue 1344493004: Preserve the ElementsKind in builtin.cc Slice early return

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins.cc

Issue 1344493004: Preserve the ElementsKind in builtin.cc Slice early return (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/builtins.cc

diff --git a/src/builtins.cc b/src/builtins.cc

index 4ad6c2117c68b581f5dbdf2f296f0644c47774d3..a68a15ad5d45cefaf2662ac829bec44fa21834df 100644

--- a/src/builtins.cc

+++ b/src/builtins.cc

@@ -527,7 +527,7 @@ BUILTIN(ArraySlice) {

if (actual_end <= actual_start) {

Handle<JSArray> result_array =

- isolate->factory()->NewJSArray(GetInitialFastElementsKind(), 0, 0);

+ isolate->factory()->NewJSArray(object->GetElementsKind(), 0, 0);

return *result_array;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »