Update fetch / loader classes to use OVERRIDE / FINAL when needed

Update fetch / loader classes to use OVERRIDE / FINAL when needed

Update fetch / loader classes to use OVERRIDE / FINAL when needed. Those are
useful for error checking or performance when the compiler supports it.

R=esprehn, abarth
BUG=333316
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164935

[eseidel, 2014-01-10 19:23:01]

I am not sure we use OVERRIDE in web/  Or we do, but not for cross-repository
interfaces.  So we have to be careful to avoid those since those make 2-sided
changes harder.

[eseidel, 2014-01-10 19:23:15]

otherwise lgtm.

[Inactive, 2014-01-10 19:28:08]

https://codereview.chromium.org/134443002/diff/1/Source/web/AssociatedURLLoad...
File Source/web/AssociatedURLLoader.cpp (left):

https://codereview.chromium.org/134443002/diff/1/Source/web/AssociatedURLLoad...
Source/web/AssociatedURLLoader.cpp:143: virtual bool
isDocumentThreadableLoaderClient() { return true; }
If you prefer, I can keep the OVERRIDE / FINAL for this web class out of this
patch. The only thing I need is to remove this
isDocumentThreadableLoaderClient() (it already returns true in the parent and
I'd to mark the parent implementation as FINAL).

FYI, OVERRIDE is already used quite a lot in web:
$ git grep OVERRIDE Source/web/ | wc -l
491

[Inactive, 2014-01-11 04:53:47]

On 2014/01/10 19:23:01, eseidel wrote:
> I am not sure we use OVERRIDE in web/  Or we do, but not for cross-repository
> interfaces.  So we have to be careful to avoid those since those make 2-sided
> changes harder.

So,
- OVERRIDE is used in web based on my greping
- The AssociatedURLLoader::ClientAdapter class is not a cross-repository class,
as a matter of fact, it is only defined in the cpp so it could not be exposed.

[Inactive, 2014-01-11 19:28:39]

I kept the OVERRIDE / FINAL changes to the web class out of this patch. I'll
take care of web separately.

[commit-bot: I haz the power, 2014-01-11 19:29:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/134443002/230001

[commit-bot: I haz the power, 2014-01-11 20:28:12]

Change committed as 164935