Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: Source/core/loader/DocumentThreadableLoader.h

Issue 134443002: Update fetch / loader classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: No OVERRIDE / FINAL in web Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/loader/DocumentLoader.h ('k') | Source/core/loader/DocumentThreadableLoaderClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/DocumentThreadableLoader.h
diff --git a/Source/core/loader/DocumentThreadableLoader.h b/Source/core/loader/DocumentThreadableLoader.h
index f8ad2f5a4acdf0df3e194f0e8c6f974feb8bfc6c..df5b67a30b1d44864f5375c7fa6bf3753cd49841 100644
--- a/Source/core/loader/DocumentThreadableLoader.h
+++ b/Source/core/loader/DocumentThreadableLoader.h
@@ -51,22 +51,22 @@ class ResourceRequest;
class SecurityOrigin;
class ThreadableLoaderClient;
-class DocumentThreadableLoader : public RefCounted<DocumentThreadableLoader>, public ThreadableLoader, private ResourceOwner<RawResource> {
+class DocumentThreadableLoader FINAL : public RefCounted<DocumentThreadableLoader>, public ThreadableLoader, private ResourceOwner<RawResource> {
WTF_MAKE_FAST_ALLOCATED;
public:
static void loadResourceSynchronously(Document*, const ResourceRequest&, ThreadableLoaderClient&, const ThreadableLoaderOptions&);
static PassRefPtr<DocumentThreadableLoader> create(Document*, ThreadableLoaderClient*, const ResourceRequest&, const ThreadableLoaderOptions&);
virtual ~DocumentThreadableLoader();
- virtual void cancel();
- virtual void setDefersLoading(bool);
+ virtual void cancel() OVERRIDE;
+ void setDefersLoading(bool);
using RefCounted<DocumentThreadableLoader>::ref;
using RefCounted<DocumentThreadableLoader>::deref;
protected:
- virtual void refThreadableLoader() { ref(); }
- virtual void derefThreadableLoader() { deref(); }
+ virtual void refThreadableLoader() OVERRIDE { ref(); }
+ virtual void derefThreadableLoader() OVERRIDE { deref(); }
private:
enum BlockingBehavior {
@@ -77,12 +77,12 @@ class DocumentThreadableLoader : public RefCounted<DocumentThreadableLoader>, pu
DocumentThreadableLoader(Document*, ThreadableLoaderClient*, BlockingBehavior, const ResourceRequest&, const ThreadableLoaderOptions&);
// RawResourceClient
- virtual void dataSent(Resource*, unsigned long long bytesSent, unsigned long long totalBytesToBeSent);
- virtual void responseReceived(Resource*, const ResourceResponse&);
- virtual void dataReceived(Resource*, const char* data, int dataLength);
- virtual void redirectReceived(Resource*, ResourceRequest&, const ResourceResponse&);
- virtual void notifyFinished(Resource*);
- virtual void dataDownloaded(Resource*, int);
+ virtual void dataSent(Resource*, unsigned long long bytesSent, unsigned long long totalBytesToBeSent) OVERRIDE;
+ virtual void responseReceived(Resource*, const ResourceResponse&) OVERRIDE;
+ virtual void dataReceived(Resource*, const char* data, int dataLength) OVERRIDE;
+ virtual void redirectReceived(Resource*, ResourceRequest&, const ResourceResponse&) OVERRIDE;
+ virtual void notifyFinished(Resource*) OVERRIDE;
+ virtual void dataDownloaded(Resource*, int) OVERRIDE;
void cancelWithError(const ResourceError&);
void didReceiveResponse(unsigned long identifier, const ResourceResponse&);
« no previous file with comments | « Source/core/loader/DocumentLoader.h ('k') | Source/core/loader/DocumentThreadableLoaderClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698