Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2152)

Unified Diff: appengine/chromium_rietveld/codereview/views_chromium.py

Issue 1344253002: Rietveld: schedule builds on buildbucket (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/chromium_rietveld/codereview/views_chromium.py
diff --git a/appengine/chromium_rietveld/codereview/views_chromium.py b/appengine/chromium_rietveld/codereview/views_chromium.py
index 6573086c9756a447dd15f49a9ad8e880ce0f7e2a..1fa7a6dda0d5eab2636c535ccf6ab987dac96f44 100644
--- a/appengine/chromium_rietveld/codereview/views_chromium.py
+++ b/appengine/chromium_rietveld/codereview/views_chromium.py
@@ -16,6 +16,7 @@
import datetime
import logging
+import random
import re
from google.appengine.api import app_identity
@@ -34,6 +35,7 @@ from django.http import HttpResponseBadRequest, HttpResponseForbidden
from django.http import HttpResponseServerError
from django.utils import simplejson as json
+from codereview import buildbucket
from codereview import decorators as deco
from codereview import decorators_chromium as deco_cr
from codereview import models
@@ -423,7 +425,15 @@ def edit_flags(request):
# Commit everything.
ndb.put_multi(jobs_to_save)
- ndb.transaction(txn)
+
+ buildbucket_roll_out_percentage = 0.1
+ if random.random() <= buildbucket_roll_out_percentage:
nodir 2015/09/17 04:23:42 Jason: should we use this or gae version splitting
jrobbins 2015/09/17 06:03:13 Yes. I think I would favor GAE version splitting
nodir 2015/09/17 17:44:17 Done.
+ buildbucket.schedule(
+ request.issue,
+ last_patchset.key.id(),
+ [b.split(':', 1) for b in new_builders])
+ else:
+ ndb.transaction(txn)
return HttpResponse('OK', content_type='text/plain')

Powered by Google App Engine
This is Rietveld 408576698