Rietveld: schedule builds on buildbucket

appengine/chromium_rietveld/codereview/views_chromium.py

 # Copyright 2008 Google Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
 #
 #     http://www.apache.org/licenses/LICENSE-2.0
 #
 # Unless required by applicable law or agreed to in writing, software
 # distributed under the License is distributed on an "AS IS" BASIS,
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
 """Views for Chromium port of Rietveld."""
 
 import datetime
 import logging
+import random
 import re
 
 from google.appengine.api import app_identity
 from google.appengine.api import datastore_errors
 from google.appengine.api import taskqueue
 from google.appengine.api import urlfetch
 from google.appengine.api import users
 from google.appengine.datastore import datastore_query
 from google.appengine.ext import ndb
 from google.appengine.runtime import DeadlineExceededError
 
 from django import forms
 from django.core.urlresolvers import reverse
 from django.http import HttpResponse, HttpResponseRedirect
 from django.http import HttpResponseBadRequest, HttpResponseForbidden
 from django.http import HttpResponseServerError
 from django.utils import simplejson as json
 
+from codereview import buildbucket
 from codereview import decorators as deco
 from codereview import decorators_chromium as deco_cr
 from codereview import models
 from codereview import models_chromium
 from codereview import responses
 from codereview import views
 
 
 ### Forms ###
 
@@ skipping 369 matching lines @@
                                       reason='',
                                       result=models.TryJobResult.TRYPENDING,
                                       master=mastername,
                                       builder=buildername,
                                       revision='',
                                       clobber=False)
         jobs_to_save.append(try_job)
 
       # Commit everything.
       ndb.put_multi(jobs_to_save)
-    ndb.transaction(txn)
+
+    buildbucket_roll_out_percentage = 0.1
+    if random.random() <= buildbucket_roll_out_percentage:

[nodir, 2015/09/17 04:23:42]

Jason: should we use this or gae version splitting? would it be OK to have
version splitting enabled for a couple of days?

[jrobbins, 2015/09/17 06:03:13]

Yes.  I think I would favor GAE version splitting because you could adjust the
percentage or disable it any time without needing to alter source code.  So,
let's try that first.

[nodir, 2015/09/17 17:44:17]

Done.

+      buildbucket.schedule(
+          request.issue,
+          last_patchset.key.id(),
+          [b.split(':', 1) for b in new_builders])
+    else:
+      ndb.transaction(txn)
 
   return HttpResponse('OK', content_type='text/plain')
 
 
 @deco.login_required
 @deco.xsrf_required
 def conversions(request):
   """/conversions - Show and edit the list of base=>source code URL maps."""
   rules = models_chromium.UrlMap.query().order(
       models_chromium.UrlMap.base_url_template).fetch()
@@ skipping 353 matching lines @@
     next_cursor = query_iter.cursor_after()
   else:
     next_cursor = cursor
 
   logging.info('Found %d entries, returned %d' % (total, len(jobs)))
   return {
     'has_more': has_more,
     'cursor': next_cursor.urlsafe() if next_cursor else '',
     'jobs': jobs
     }