Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1344213004: Avoid CTFontCreateCopyWithAttributes. (Closed)

Created:
5 years, 3 months ago by bungeman-skia
Modified:
5 years, 3 months ago
Reviewers:
erikchen, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Avoid CTFontCreateCopyWithAttributes. It appears that CTFontCreateCopyWithAttributes and CTFontCreateCopyWithSymbolicTraits share similar issues with the default font on OSX10.10. CTFontCreateWithFontDescriptor cannot be used as it will not work with webfonts. Since this is all low-level use, create the CTFonts from the underlying CGFonts directly. BUG=chromium:524646 Committed: https://skia.googlesource.com/skia/+/d3296717b9d0930237be3502b82ab94d0b4d177f Committed: https://skia.googlesource.com/skia/+/7cbeaae8bb42c386145cd020f714f0eac8021dc2

Patch Set 1 : This one breaks non-system fonts. #

Patch Set 2 : Doesn't break webfonts. #

Total comments: 4

Patch Set 3 : Convert other uses as well. #

Patch Set 4 : Refactor. #

Total comments: 4

Patch Set 5 : Address comment. #

Patch Set 6 : Fix synthetic bold italic. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -25 lines) Patch
M src/ports/SkFontHost_mac.cpp View 1 2 3 4 5 6 chunks +67 lines, -25 lines 0 comments Download

Messages

Total messages: 42 (16 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344213004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344213004/1
5 years, 3 months ago (2015-09-16 17:50:12 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344213004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344213004/20001
5 years, 3 months ago (2015-09-16 19:44:07 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-16 19:49:53 UTC) #7
erikchen
On 2015/09/16 19:49:53, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 3 months ago (2015-09-16 20:44:04 UTC) #8
erikchen
https://codereview.chromium.org/1344213004/diff/20001/src/ports/SkFontHost_mac.cpp File src/ports/SkFontHost_mac.cpp (right): https://codereview.chromium.org/1344213004/diff/20001/src/ports/SkFontHost_mac.cpp#newcode775 src/ports/SkFontHost_mac.cpp:775: fCTUnrotatedFont.reset(CTFontCreateWithGraphicsFont(baseCGFont, textSize, nullptr, nit: The textSize parameter here looks ...
5 years, 3 months ago (2015-09-16 20:50:28 UTC) #10
erikchen
lgtm
5 years, 3 months ago (2015-09-16 20:50:37 UTC) #11
bungeman-skia
https://codereview.chromium.org/1344213004/diff/20001/src/ports/SkFontHost_mac.cpp File src/ports/SkFontHost_mac.cpp (right): https://codereview.chromium.org/1344213004/diff/20001/src/ports/SkFontHost_mac.cpp#newcode775 src/ports/SkFontHost_mac.cpp:775: fCTUnrotatedFont.reset(CTFontCreateWithGraphicsFont(baseCGFont, textSize, nullptr, On 2015/09/16 20:50:28, erikchen wrote: > ...
5 years, 3 months ago (2015-09-17 16:26:06 UTC) #12
bungeman-skia
5 years, 3 months ago (2015-09-17 16:26:43 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344213004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344213004/40001
5 years, 3 months ago (2015-09-17 16:39:59 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-17 18:21:01 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344213004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344213004/60001
5 years, 3 months ago (2015-09-18 22:25:10 UTC) #20
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-18 22:31:06 UTC) #22
erikchen
On 2015/09/18 22:31:06, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 3 months ago (2015-09-19 00:14:46 UTC) #23
reed1
lgtm
5 years, 3 months ago (2015-09-19 00:31:06 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344213004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344213004/60001
5 years, 3 months ago (2015-09-19 03:12:32 UTC) #27
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/d3296717b9d0930237be3502b82ab94d0b4d177f
5 years, 3 months ago (2015-09-19 03:13:10 UTC) #28
Mark Mentovai
https://codereview.chromium.org/1344213004/diff/60001/src/ports/SkFontHost_mac.cpp File src/ports/SkFontHost_mac.cpp (right): https://codereview.chromium.org/1344213004/diff/60001/src/ports/SkFontHost_mac.cpp#newcode715 src/ports/SkFontHost_mac.cpp:715: // CTFontCreateCopyWithAttributes or CTFontCreateCopyWithSymbolicTraits cannot be used on 10.10 ...
5 years, 3 months ago (2015-09-19 03:18:41 UTC) #29
bungeman-skia
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1354323002/ by bungeman@google.com. ...
5 years, 3 months ago (2015-09-19 06:03:09 UTC) #30
bungeman-skia
https://codereview.chromium.org/1344213004/diff/60001/src/ports/SkFontHost_mac.cpp File src/ports/SkFontHost_mac.cpp (right): https://codereview.chromium.org/1344213004/diff/60001/src/ports/SkFontHost_mac.cpp#newcode715 src/ports/SkFontHost_mac.cpp:715: // CTFontCreateCopyWithAttributes or CTFontCreateCopyWithSymbolicTraits cannot be used on 10.10 ...
5 years, 3 months ago (2015-09-19 06:25:47 UTC) #31
erikchen
On 2015/09/19 06:25:47, bungeman1 wrote: > https://codereview.chromium.org/1344213004/diff/60001/src/ports/SkFontHost_mac.cpp > File src/ports/SkFontHost_mac.cpp (right): > > https://codereview.chromium.org/1344213004/diff/60001/src/ports/SkFontHost_mac.cpp#newcode715 > ...
5 years, 3 months ago (2015-09-21 18:05:47 UTC) #32
bungeman-skia
On 2015/09/21 18:05:47, erikchen wrote: > On 2015/09/19 06:25:47, bungeman1 wrote: > > > https://codereview.chromium.org/1344213004/diff/60001/src/ports/SkFontHost_mac.cpp ...
5 years, 3 months ago (2015-09-21 18:15:53 UTC) #33
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344213004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344213004/100001
5 years, 3 months ago (2015-09-22 14:59:27 UTC) #35
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-22 15:03:55 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1344213004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1344213004/100001
5 years, 3 months ago (2015-09-22 16:54:20 UTC) #40
commit-bot: I haz the power
Committed patchset #6 (id:100001) as https://skia.googlesource.com/skia/+/7cbeaae8bb42c386145cd020f714f0eac8021dc2
5 years, 3 months ago (2015-09-22 16:55:00 UTC) #41
bungeman-skia
5 years, 3 months ago (2015-09-24 14:08:11 UTC) #42
Message was sent while issue was closed.
On 2015/09/22 16:55:00, commit-bot: I haz the power wrote:
> Committed patchset #6 (id:100001) as
> https://skia.googlesource.com/skia/+/7cbeaae8bb42c386145cd020f714f0eac8021dc2

Note that this uncovered yet another bug in CoreGraphics, which is worked around
in https://codereview.chromium.org/1362053003/ .

Powered by Google App Engine
This is Rietveld 408576698