Issue 134393002: <webview>: Fix Javascript error on attributeChanged callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 134393002: <webview>: Fix Javascript error on attributeChanged callback (Closed)

Created:
6 years, 11 months ago by Fady Samuel

Modified:
6 years, 11 months ago

Reviewers:
sadrul

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

<webview>: Fix Javascript error on attributeChanged callback Modifying attributes on webview prior to attaching the internal_ to <webview> would throw a javascript error. This CL addresses this. BUG=333302 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244270

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/renderer/resources/extensions/web_view.js	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/134393002/1

6 years, 11 months ago (2014-01-10 19:49:18 UTC) #3

Message was sent while issue was closed.

Change committed as 244270

Expand Messages | Collapse Messages