chrome/renderer/resources/extensions/web_view.js - Issue 134393002: <webview>: Fix Javascript error on attributeChanged callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/web_view.js

Issue 134393002: <webview>: Fix Javascript error on attributeChanged callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/resources/extensions/web_view.js

diff --git a/chrome/renderer/resources/extensions/web_view.js b/chrome/renderer/resources/extensions/web_view.js

index f9db94f3953bb6490aa8f8e0a7bc56b278cb2b9c..f8ae2cb7dc27889a51297212f8a9b128b100937c 100644

--- a/chrome/renderer/resources/extensions/web_view.js

+++ b/chrome/renderer/resources/extensions/web_view.js

@@ -958,6 +958,9 @@ function registerWebViewElement() {

};

proto.attributeChangedCallback = function(name, oldValue, newValue) {

+ if (!this.internal_) {

+ return;

+ }

var internal = this.internal_(secret);

internal.handleWebviewAttributeMutation_(name, oldValue, newValue);

};

« no previous file with comments | « no previous file | no next file » | no next file with comments »